diff options
| author | Ondrej Holy <oholy@redhat.com> | 2016-11-10 14:21:22 +0100 |
|---|---|---|
| committer | Ondrej Holy <oholy@redhat.com> | 2016-11-18 09:02:54 +0100 |
| commit | f760443a989a5d2f3e5b768c2fa429cdfe653917 (patch) | |
| tree | c6e21df55121464e60f831a1abcb0da01bff194e /monitor | |
| parent | 5fe704eb12c21c8f0ae46b61bb8843d7e7192abc (diff) | |
| download | gvfs-f760443a989a5d2f3e5b768c2fa429cdfe653917.tar.gz | |
udisks2: Always use generic notification when unmounting
"You can now unplug %s\n" is used for mounts with filesystem,
"%s has been unmounted\n" is used otherwise when unmounting.
It is confusing to say "unplug" for drives with multiple mounts,
or for drives, which need to be ejected, or stopped. I think
"unplug" should be used only when ejecting, or stopping. It might
lead to data loss if user unplug the device after unmounting one
of several mounts.
https://bugzilla.gnome.org/show_bug.cgi?id=774192
Diffstat (limited to 'monitor')
| -rw-r--r-- | monitor/udisks2/gvfsudisks2mount.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/monitor/udisks2/gvfsudisks2mount.c b/monitor/udisks2/gvfsudisks2mount.c index 29f2a3d5..860903c6 100644 --- a/monitor/udisks2/gvfsudisks2mount.c +++ b/monitor/udisks2/gvfsudisks2mount.c @@ -962,7 +962,7 @@ unmount_do (UnmountData *data, if (data->mount_operation != NULL) gvfs_udisks2_unmount_notify_start (data->mount_operation, G_MOUNT (data->mount), NULL, - (data->filesystem == NULL)); + TRUE); /* Use the umount(8) command if there is no block device / filesystem */ if (data->filesystem == NULL) |