| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Fix a runtime warning introduced by 32983ccd7e3d ("MTP: Fix error
semantics for do_pull/do_push/do_make_directory") which occurs when
pulling and the destination does not exist.
https://bugzilla.gnome.org/show_bug.cgi?id=734305
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When an application tries to save a larger key-value pair than the size
of the journal, it triggers the journal to be flushed to make space for
the entry and the operation is then retried, but it never fits, and the
loop continues forever.
This patch removes the endless retry loop and retries the operation
only once after the flush. We know that there isn't enough space for
the entry if it fails after the flush.
https://bugzilla.gnome.org/show_bug.cgi?id=637095
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allow reading files with a "." component in the path. This is a
followup to 46bdbf1d4596 ('archive: Ignore filenames consisting of a
single "."'), which allowed the archive backend to enumerate an archive
with a single "." in the path.
Implement this with a generic function to fixup an archive_entry path,
and use this wherever archive_entry_pathname() is used.
https://bugzilla.gnome.org/show_bug.cgi?id=729463
|
|
|
|
|
|
|
| |
Unfortunately, the clever trick to avoid string copying causes leaks
because it inserts NULLs in the middle of a NULL-terminated array.
https://bugzilla.gnome.org/show_bug.cgi?id=729463
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Ignore parameters of the file's content type since these break
applications which make use of the content type.
E.g. If the server returns a type such as "text/plain; charset=utf-8",
the file won't open in a text editor.
https://bugzilla.gnome.org/show_bug.cgi?id=676627
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
Don't unlock an unlocked mutex since this causes an abort() with the
latest glib (and is undefined anyway).
https://bugzilla.gnome.org/show_bug.cgi?id=735381
|
| |
|
|
|
|
|
|
|
|
|
|
| |
See https://live.gnome.org/GnomeGoals/InstalledTests for more information.
Those tests will also be executed on http://build.gnome.org. For now we run
all our suite as one big test
It's still possible to run `make check` with locally uninstalled tests.
https://bugzilla.gnome.org/show_bug.cgi?id=734370
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=594507
|
|
|
|
|
|
|
| |
Force unmount the backend when the resolved data changes (most likely
when the remote service disappears).
https://bugzilla.gnome.org/show_bug.cgi?id=594507
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Retry operations that return ARCHIVE_RETRY since it indicates that the
operation has failed, the archive_entry is not valid, and the operation
should be retried to see if it succeeds.
This fixes a segfault on a truncated archive where
archive_read_next_header would return ARCHIVE_RETRY and the backend
would continue to try and use the invalid archive_entry that was
returned.
https://bugzilla.gnome.org/show_bug.cgi?id=735120
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
handler and do_query_info()
The LIBMTP_Get_Storage() call in STORE_ADDED event handler needs
to be called with backend mutex held, otherwise it races with
iteration over storages list in do_query_info() as the latter
attempts to retrieve information about storage.
The issues occur when several stores are added at the same time,
because after a store is added, Nautilus immediately queries it
for info.
Also, backend reference should probably also be released in cases
when LIBMTP_Get_Storage() fails.
Signed-off-by: Rok Mandeljc <rok.mandeljc@gmail.com>
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Allow specifying G_FILE_CREATE_REPLACE_DESTINATION when using gvfs-save
with the -u flag or --unlink. I chose this because "unlink" represents
what G_FILE_CREATE_REPLACE_DESTINATION does in principle: it unlinks the
destination before replacing it, thereby losing any permissions or other
attributes of the file.
https://bugzilla.gnome.org/show_bug.cgi?id=734695
|
|
|
|
|
|
|
| |
Send a "success" response earlier when enumerating to allow infos to be
sent incrementally rather than batched up until the end.
https://bugzilla.gnome.org/show_bug.cgi?id=734695
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=734695
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=734695
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=734695
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are a bunch of semantic inconsistencies in the existing
implementations of these functions, when compared with the GIO
docs for making dirs and copying files.
This change fixes those problems, and also ensures that in the
pull/push cases, the destination is deleted at the last possible
moment, in the case of overwrites.
Also, certain other methods had their error code changed from
NOT_REGULAR_FILE to PERMISSION_DENIED when an operation is
attempted on a storage. This leads to less surprising errors
for users.
https://bugzilla.gnome.org/show_bug.cgi?id=734305
|
|
|
|
|
|
|
|
|
|
| |
Only attempt to free the connection if it is non-NULL, to prevent
warnings like the following:
** (process:30854): CRITICAL **: g_vfs_ftp_connection_free: assertion 'conn != NULL' failed
The connection can be NULL if g_vfs_ftp_connection_new is cancelled.
https://bugzilla.gnome.org/show_bug.cgi?id=591054
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is data waiting on an FTP connection and we didn't request it.
It's not ours and we have no way to clear it. Just makr this connection
as unusable.
Most likely this is the server notifying us about a timeout or other
connection abort, so it's a good idea to treat it as an error anyway.
Also includes a new debug message for when we mark a connection as
unusuable and why.
https://bugzilla.gnome.org/show_bug.cgi?id=591054
|
|
|
|
|
|
|
|
|
| |
Qhen acquiring a cached connection, it might have timeout'ed or
otherwise not be available anymore. We don't want these connection
errors to propagate into the job we're handling and instead just acquire
the next connection.
https://bugzilla.gnome.org/show_bug.cgi?id=591054
|