| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These checks for DBUS_SESSION_BUS_ADDRESS were added to solve
https://bugzilla.gnome.org/show_bug.cgi?id=526454,
in which non-X11-session processes (for example a system service),
or processes under su or similar inside an X11 session, could cause
a dbus-daemon to be autolaunched via dbus-launch. If there was no
X11 display to represent the lifetime of a session, the dbus-daemon
would potentially run forever, causing a "leaked" process;
additionally, other uses of D-Bus by the same uid would start more
dbus-daemons.
This becomes potentially problematic on systems with the "user bus"
model introduced in dbus 1.10: libdbus, GDBus and sd-bus will now
all try the per-uid socket XDG_RUNTIME_DIR/bus before attempting
autolaunch, so if those are known to be the only implementations in
use on a "legacy-free" system, setting DBUS_SESSION_BUS_ADDRESS is
unnecessary. Check for that socket before giving up.
XDG_RUNTIME_DIR/bus as implemented by dbus 1.10 with systemd avoids
several of the down sides of autolaunching: it will never start more
than one session bus per uid, and the socket and bus will automatically
be cleaned up when the corresponding "systemd --user" exits.
https://bugzilla.gnome.org/show_bug.cgi?id=756420
|
| |
|
|
|
|
|
|
|
| |
Complicated file name handling on google backend leads to display name
loss if in-fs copy and move operation is proceeded e.g. using Nautilus.
Proper fix will require larger changes for the whole platform. Therefore
fail the job preferably to avoid display name loss...
https://bugzilla.gnome.org/show_bug.cgi?id=755701
|
| |
|
|
|
|
|
|
|
|
|
|
| |
We should finish constructing the innards of the object and not leave
it in an inconsistent state when we hit an error. The other option
would be to litter the rest of the code with NULL checks, but that
would be ugly and prone to errors.
We should also ensure that the reference counting stays consistent with
the non-error paths.
https://bugzilla.gnome.org/show_bug.cgi?id=755805
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Files without the parent are currently shown in google backend root.
You can see many files consequently, which are not shown in your google
drive folder on the web. Those files can be shared with you, or you
opened them in some google applications (i.e. google docs). Mark those
files as hidden to see same files as you can see on the web. Also mark
the files as undeletable, because it is not possible to delete them
from the obvious reason.
https://bugzilla.gnome.org/show_bug.cgi?id=756644
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Commit 7373acf changed file monitor construction to be really
synchronous. Unfortunately there is missing g_object_ref for d-bus
connection and the connection is unrefed after use. Subsequent read
of the unrefed connection cause crash with following critical:
(firefox:29844): GLib-GIO-CRITICAL **: g_dbus_connection_is_closed:
assertion 'G_IS_DBUS_CONNECTION (connection)' failed
Do not store the connection, because it isn't neccesary with the
synchronous construction.
https://bugzilla.gnome.org/show_bug.cgi?id=756153
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
Commit 957fff5 modified d-bus session services names, but the change
was incomplete and test suite is broken conseqently. All tests fail with:
Error mounting location: volume doesn't implement mount
https://bugzilla.gnome.org/show_bug.cgi?id=755760
|
| |
|
|
|
|
|
|
|
|
|
| |
The GVariantBuilder is unable to create any GVariant for
an untyped array - while an empty vector is a valid variant,
it is not valid for an untyped array.
Passing the resulting null to gvfs_dbus_daemon_complete_cancel()
causes gvfs to abort with a g_error().
https://bugzilla.gnome.org/show_bug.cgi?id=756105
|
| |
|
|
|
|
|
|
| |
Currently g_errprint is used and thus a message doesn't end up in a logs.
Use g_warning to log the message and also replace g_return_if_fail,
because proxy creation failure isn't programmer error.
https://bugzilla.gnome.org/show_bug.cgi?id=755805
|
| |
|
|
|
|
|
| |
Accesses to the drives, volumes and mounts hash tables should be
guarded by the proxy_vm mutex.
https://bugzilla.gnome.org/show_bug.cgi?id=755805
|
| |
|
|
|
|
|
|
| |
When using "systemd --user" in conjunction with "dbus-daemon --session
--systemd-activation", this ensures that each daemon is correctly placed
in its own cgroup, instead of being treated as part of dbus.service.
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=755760
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This naming is mandatory for the system bus, but is also recommended
for the session bus.
The D-Bus maintainers recommend that all activatable session services'
service files are named according to the bus name, so that any conflict
is resolved in a deterministic way. If the services are in different
directories (precedence levels) the result is the same as it is now:
the higher precedence "wins". If the services are in the same
directory, either one overwrites the other and consistently "wins",
or a packaging system like dpkg prevents co-installation.
If the service files were named differently, it would be possible
to have two implementations for the same name. dbus-daemon resolves
this by choosing one arbitrarily, not necessarily the same one every
time. systemd's kdbus support is more strict (or less concerned with
backwards compatibility), and treats this situation as an error.
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=755760
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
g_file_monitor_file() is a sync call anyway, so doing some sync i/o
in the constructor doesn't make a difference, and doing so avoids
races where you would not get change events for operations you do.
We don't actually need to wait for the subscribe event, and proxy
construction in this case does not do any i/o, so we're really only
doing sync i/o to look up the connection, and it should be cached from
the earlier call in g_daemon_file_monitor_file(), so in practice
this should make little difference.
https://bugzilla.gnome.org/show_bug.cgi?id=749317
|
| |
|
|
|
|
|
|
|
|
| |
Progress isn't reported currently. However it is guaranteed that
the progress callback will be called at least after all data has
been transferred according the GIO documentation. Nautilus shows
some weird progress info when moving and copying consequently. Emit
progress callback with total size to fix this issue.
https://bugzilla.gnome.org/show_bug.cgi?id=755775
|
| |
|
|
|
|
|
|
|
|
|
|
| |
The existing code sanitizes relative symlinks but not absolute symlinks
when resolving them. But this can cause issues when looking up the
resolved path (e.g. if it has a trailing slash, the correct information
will not be returned because it will not get the parent directory
correctly).
To fix this, sanitize both absolute and relative paths.
https://bugzilla.gnome.org/show_bug.cgi?id=755303
|
| |
|
|
| |
Signed-off-by: Trần Ngọc Quân <vnwildman@gmail.com>
|
| | |
|
| |
|
|
|
|
| |
Otherwise nautilus will offer the wrong action in its UI.
https://bugzilla.gnome.org/show_bug.cgi?id=753934
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the remote connection(s) are closed (e.g. the remote host is
rebooted), ensure that g_vfs_backend_force_unmount is only called once.
This avoids a warning like the following:
forced_unregister_mount_callback
forced_unregister_mount_callback
** (process:12472): WARNING **: Error unregistering mount: Mountpoint
not registered (g-io-error-quark, 16)
Additionally, remove some backend member variables.
https://bugzilla.gnome.org/show_bug.cgi?id=753311
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
destroy_connection() is called twice when setup of data connection failed.
Consequently g_hash_table_destroy() is called on already destroyed hash
table on finalize. Set conn->expected_replies to NULL in destroy_connection()
to fix the issue.
There is another crash on force unmount when setup of data connection failed.
fail_jobs() is called on already destroyed connection. Check usability of
the connection before use to avoid the crash.
Finally move the hast table initialization into the setup_connection,
because the initialization in g_vfs_backend_sftp_init() is confusing.
https://bugzilla.gnome.org/show_bug.cgi?id=753311
|
| |
|
|
|
|
|
|
| |
Unify send_reply debug messages for all jobs. Always indicate failure
and include error message. Indicate some other info (i.e. offset,
size) for some jobs (i.e. seek, read, write).
https://bugzilla.gnome.org/show_bug.cgi?id=755104
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=754791
|
| |
|
|
|
|
|
| |
Commit 59325df refactored daemon code a bit. Function do_name_acquired
is no more needed. Remove this function to avoid following warnings:
daemon-main.c:347:1: warning: ‘do_name_acquired’ defined but not used
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=753838
|
| |
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=754729
|
