| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Recent backend is based on GtkRecentManager and calls gtk_init.
Unfortunatelly, gtk_init aborts with "cannot open display: " warning
if DISPLAY variable is not set. It happens e.g. when recent backend
is spawned from a terminal without a graphical session. Systemd user
units make this even worse and this happens also in graphical session
if gvfs was running before the graphical session starts...
Let's remove gtk_init call. It seems that GtkRecentManager works
properly without it, because the display isn't really needed for it.
https://bugzilla.gnome.org/show_bug.cgi?id=773300
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
g_dbus_connection_flush_sync causes troubles in certain cases when
using multiple threads. The problem occurs when there are ongoing
gvfs_metadata_call_set_sync calls. It blocks threads e.g. when
moving files over Nautilus. Nautilus freezes sometimes due to it.
Use sync methods instead of flushing dbus. I don't see any significant
slowdown when using sync methods instead of the flushing according
to my testing. It fixes hangs in Nautilus and moving in Nautilus is
almost instant again.
https://bugzilla.gnome.org/show_bug.cgi?id=757747
|
|
|
|
|
|
|
|
|
|
| |
Some of the lists used by the metabuilder have items appended to them. Appending
to a list is done in linear time and this highly affects efficiency. In order to
fix this, use GQueue which supports appending in constant time.
Modified by Ondrej Holy <oholy@redhat.com>.
https://bugzilla.gnome.org/show_bug.cgi?id=757747
|
|
|
|
|
|
|
|
|
|
|
| |
The metabuilder stores files and data in sorted lists. An insertion into a sorted
list is done in linear time, which highly affects efficiency. In order to fix
this, use GSequence instead which does insertion and deletion in logarithmic
time.
Modified by Ondrej Holy <oholy@redhat.com>.
https://bugzilla.gnome.org/show_bug.cgi?id=757747
|
|
|
|
|
|
|
|
| |
Client object is not freed even if there isn't more backends.
Free the client in order to avoid potential use-after-free crashes
caused by some avahi client activity.
https://bugzilla.gnome.org/show_bug.cgi?id=631023
|
|
|
|
|
|
|
|
|
| |
The dnssd backend was designed to run under one common daemon
process, however, new daemon is always spawn for each host
(i.e. backend) currently. Set common dbus mountpoint in order
to use one daemon process for all backends.
https://bugzilla.gnome.org/show_bug.cgi?id=631023
|
|
|
|
|
|
|
|
| |
Browser objects are not currently freed by remove_browsers call,
just the list is emptied. Free the browser objects for sure in order
to avoid some use-after-free crashes.
https://bugzilla.gnome.org/show_bug.cgi?id=631023
|
|
|
|
|
|
|
|
| |
Resolvers are not currently removed on client failure. It might
potentialy lead to some use-after-free crashes. Remove resolver
objects also on client failures.
https://bugzilla.gnome.org/show_bug.cgi?id=631023
|
|
|
|
|
|
|
|
| |
SMB backend mount operation might be still running when finalize is called.
Increase backend reference count when calling g_file_mount_enclosing_volume
in order to be sure that finalize is called after the operation is done.
https://bugzilla.gnome.org/show_bug.cgi?id=712235
|
|
|
|
|
|
|
|
| |
Not all signal handlers has been removed in finalize by commit 45c4dcc.
Disconnect rest of the signal handlers in order to avoid potential
crashes...
https://bugzilla.gnome.org/show_bug.cgi?id=712235
|
|
|
|
|
|
|
|
|
|
|
|
| |
"You can now unplug %s\n" is used for mounts with filesystem,
"%s has been unmounted\n" is used otherwise when unmounting.
It is confusing to say "unplug" for drives with multiple mounts,
or for drives, which need to be ejected, or stopped. I think
"unplug" should be used only when ejecting, or stopping. It might
lead to data loss if user unplug the device after unmounting one
of several mounts.
https://bugzilla.gnome.org/show_bug.cgi?id=774192
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=604116
|
|
|
|
|
|
|
|
| |
IPv6 server includes brackets in GMountSpec, smbclient doesn't. Commit
4012d70 fixed IPv6 handling for SMB backend. Share and use the modified
create_smb_uri() function in order to fix the IPv6 handling.
https://bugzilla.gnome.org/show_bug.cgi?id=604116
|
|
|
|
|
|
|
|
|
|
|
| |
IPv6 server includes brackets in GMountSpec, smbclient doesn't. Remove
the brackets from the uri before usage in smbclient functions.
The IPv6 uris can be consequently used in the following format (port
isn't mandatory), e.g.:
gvfs-mount smb://[::1]:139/
https://bugzilla.gnome.org/show_bug.cgi?id=604116
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Mount entry might not be found e.g. for bind mounts, btrfs subvolumes.
Let's assume that the home trash is on filesystem with trusted
notifications.
https://bugzilla.gnome.org/show_bug.cgi?id=747540
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The default appears to be to translate all entries. This rule never takes
effect, the path to /action/message and /action/description is wrong (/action
is not a root node). Since we wanted them to be translated, it doesn't matter.
But it also translates all other tags (vendor, allow_any, etc.) and that
causes polkit to be unhappy, it can't handle the various language versions of
"no"
** (polkitd:27434): WARNING **: Unknown PolkitImplicitAuthorization string
'tidak'
Switch to a default of "no" and explicitly include the message and description
strings to be translated.
https://bugzilla.gnome.org/show_bug.cgi?id=768707
|
| |
|
| |
|
| |
|
|
|
|
| |
This reverts commit 61626538c43164880cd0942dc41530497e1761f2.
|
|
|
|
| |
This reverts commit 4d2562b33c07de1b817da8ba44afe07cac5e66c8.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
Volume is not included currently if it has multiple mount points
and one of them is not considered as user interesting. Change this
logic and include all volumes with at least one user interesting
mount point.
https://bugzilla.gnome.org/show_bug.cgi?id=772306
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
System mounts (i.e. autofs) can be considered as user interesting
currently if mount paths are user interesting. However, we should
not handle those mounts as GMounts, because consequently redundant
mounts are offered by volume monitor. It also causes automounts of
autofs filesystems.
$ mount | grep /media/test
systemd-1 on /media/test type autofs ...
localhost:/home/oholy on /media/test type nfs4 ...
https://bugzilla.gnome.org/show_bug.cgi?id=771740
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mount path is used to match mount points currently, however device
path should be used also in order to be sure it is really corresponding
mount point. Same mount path can be used for multiple mount entries
(it is also used e.g. for autofs).
$ mount | grep /media/test
systemd-1 on /media/test type autofs ...
localhost:/home/oholy on /media/test type nfs4 ...
https://bugzilla.gnome.org/show_bug.cgi?id=771740
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Dav backend always tries to mount WebDAV share with the shortest prefix.
Unfortunately, it never tries the root when looking for it excepting
the case, when the root is already specified.
https://bugzilla.gnome.org/show_bug.cgi?id=770549
|
|
|
|
|
|
|
|
|
| |
Dump_Device_Info spews a lot of stuff to stderr which ends up
getting captured on systemd based distros.
Let's use a simpler function that doesn't spew everywhere.
https://bugzilla.gnome.org/show_bug.cgi?id=770916
|
| |
|
| |
|
| |
|