| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
gvfs- tools are deprecated by the commit 2f28fa4 and should not be used.
Let's remove the notes about them from doap and README files.
|
| |
|
| |
|
|
|
|
|
|
|
| |
The caller's error is not duplicated since the commit 811aace. It might
cause segfaults, because gvfsdaemonvfs is not modified appropriately.
https://bugzilla.gnome.org/show_bug.cgi?id=747412
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=772849
|
|
|
|
|
|
|
|
|
|
|
| |
The "[]:" chars are omitted currently when encoding uri, because they
are valid for IPv6. This causes problems in some cases, e.g. output from
g_file_get_uri(g_file_new_for_uri("dav+sd://foo%3Abar._webdav._tcp.local"))
is "dav+sd://foo:bar._webdav._tcp.local/", which is obviously wrong. Add
gvfs_is_ipv6 in order to detect IPv6 addresses and encode also "[]:" chars
in other cases. Use gvfs_is_ipv6 to detect IPv6 also in some backends.
https://bugzilla.gnome.org/show_bug.cgi?id=772849
|
|
|
|
|
|
|
|
| |
gvfsd-dnssd aborts currently if invalid encoded triple is provided
and g_vfs_dns_sd_resolver_resolve is called. Return error instead
of abort.
https://bugzilla.gnome.org/show_bug.cgi?id=772849
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If, for example, "/home" is a symlink to "/mnt/home", and the users's $HOME
is "/home/user", then the code won't correctly recognize unix mount, because
it just walks up the path removing trailing components. Consequently, "/" is
used to determine filesystem type instead of "/mnt/home". It will cause
problems if "/mnt/home" is e.g. NFS, which is handled differently than local
filesystem.
It uses newly added g_unix_mount_for. Bump GLib dependency accordingly.
https://bugzilla.gnome.org/show_bug.cgi?id=771431
|
|
|
|
|
|
|
|
|
|
| |
The gio cmd tool doesn't handle --help/-h for each command.
The expected commandline is the following: "gio help [command]".
Detect this case and call the help properly from wrapper.
This also fixes various xdg-utils scripts.
https://bugzilla.gnome.org/show_bug.cgi?id=775938
|
|
|
|
|
|
|
|
| |
Flags are not passed in write operations on the client side currently,
so the daemons always use G_FILE_CREATE_NONE when writting. Pass the
flags in to fix this regression...
https://bugzilla.gnome.org/show_bug.cgi?id=747412
|
|
|
|
|
|
| |
The uri variable is just set, but never used.
https://bugzilla.gnome.org/show_bug.cgi?id=747412
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
g_dbus_connection_flush_sync causes troubles in certain cases when
using multiple threads. The problem occurs when there are ongoing
gvfs_metadata_call_set_sync calls. It blocks threads e.g. when
moving files over Nautilus. Nautilus freezes sometimes due to it.
Use sync methods instead of flushing dbus. I don't see any significant
slowdown when using sync methods instead of the flushing according
to my testing. It fixes hangs in Nautilus and moving in Nautilus is
almost instant again.
https://bugzilla.gnome.org/show_bug.cgi?id=757747
|
|
|
|
|
|
|
|
|
| |
The file->children condition is always true at this point,
child->children should be there instead in order to speed up
processing. This fix doesn't affect the functionality, it just
slightly improves processing.
https://bugzilla.gnome.org/show_bug.cgi?id=757747
|
|
|
|
|
|
|
|
|
|
| |
Some of the lists used by the metabuilder have items appended to them. Appending
to a list is done in linear time and this highly affects efficiency. In order to
fix this, use GQueue which supports appending in constant time.
Modified by Ondrej Holy <oholy@redhat.com>.
https://bugzilla.gnome.org/show_bug.cgi?id=757747
|
|
|
|
|
|
|
|
|
|
|
| |
The metabuilder stores files and data in sorted lists. An insertion into a sorted
list is done in linear time, which highly affects efficiency. In order to fix
this, use GSequence instead which does insertion and deletion in logarithmic
time.
Modified by Ondrej Holy <oholy@redhat.com>.
https://bugzilla.gnome.org/show_bug.cgi?id=757747
|
|
|
|
|
|
|
|
| |
Add GVFS_NFS_DEBUG environment variable for controlling libnfs log
level. libnfs doesn't contain a lot of debug prints, however, it
might be useful in the future...
Bump libnfs version accordingly.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
The dnssd backend was designed to run under one common daemon
process, however, new daemon is always spawn for each host
(i.e. backend) currently. Set common dbus mountpoint in order
to use one daemon process for all backends.
https://bugzilla.gnome.org/show_bug.cgi?id=631023
|
|
|
|
|
|
|
|
| |
Browser objects are not currently freed by remove_browsers call,
just the list is emptied. Free the browser objects for sure in order
to avoid some use-after-free crashes.
https://bugzilla.gnome.org/show_bug.cgi?id=631023
|
|
|
|
|
|
|
|
| |
Resolvers are not currently removed on client failure. It might
potentialy lead to some use-after-free crashes. Remove resolver
objects also on client failures.
https://bugzilla.gnome.org/show_bug.cgi?id=631023
|
|
|
|
|
|
|
|
| |
Client object is not freed even if there isn't more backends.
Free the client in order to avoid potential use-after-free crashes
caused by some avahi client activity.
https://bugzilla.gnome.org/show_bug.cgi?id=631023
|
|
|
|
|
|
|
|
| |
SMB backend mount operation might be still running when finalize is called.
Increase backend reference count when calling g_file_mount_enclosing_volume
in order to be sure that finalize is called after the operation is done.
https://bugzilla.gnome.org/show_bug.cgi?id=712235
|
|
|
|
|
|
|
|
| |
Not all signal handlers has been removed in finalize by commit 45c4dcc.
Disconnect rest of the signal handlers in order to avoid potential
crashes...
https://bugzilla.gnome.org/show_bug.cgi?id=712235
|
|
|
|
|
|
| |
GSimpleAsyncResult is deprecated in favour of GTask and should be replaced.
https://bugzilla.gnome.org/show_bug.cgi?id=747412
|
|
|
|
|
|
|
|
|
|
|
|
| |
"You can now unplug %s\n" is used for mounts with filesystem,
"%s has been unmounted\n" is used otherwise when unmounting.
It is confusing to say "unplug" for drives with multiple mounts,
or for drives, which need to be ejected, or stopped. I think
"unplug" should be used only when ejecting, or stopping. It might
lead to data loss if user unplug the device after unmounting one
of several mounts.
https://bugzilla.gnome.org/show_bug.cgi?id=774192
|
| |
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=604116
|
|
|
|
|
|
|
|
|
| |
Replace custom g_string_append_encoded() by g_string_append_uri_escaped().
The functions are identical except additional UTF-8 support, which can
be simply disabled by allow_utf8 parameter. The custom function was used
probably because the g_string_append_uri_escaped has been added later.
https://bugzilla.gnome.org/show_bug.cgi?id=604116
|
|
|
|
|
|
|
|
| |
IPv6 server includes brackets in GMountSpec, smbclient doesn't. Commit
4012d70 fixed IPv6 handling for SMB backend. Share and use the modified
create_smb_uri() function in order to fix the IPv6 handling.
https://bugzilla.gnome.org/show_bug.cgi?id=604116
|
|
|
|
|
|
|
|
|
|
|
| |
IPv6 server includes brackets in GMountSpec, smbclient doesn't. Remove
the brackets from the uri before usage in smbclient functions.
The IPv6 uris can be consequently used in the following format (port
isn't mandatory), e.g.:
gvfs-mount smb://[::1]:139/
https://bugzilla.gnome.org/show_bug.cgi?id=604116
|
|
|
|
|
|
|
|
| |
gvfs_udisks2_volume_get_uuid returns NULL regardless of the output
from udisks_block_get_id_uuid currently. Set volume->uuid property
and handle its changes properly.
https://bugzilla.gnome.org/show_bug.cgi?id=772894
|
|
|
|
|
|
|
|
|
| |
gvfsd(1) See Also reference should list gvfs(7) not gvfs(8).
man/gvfs.xml specifies a section number of 7 for itself.
Commit message was modified by Ondrej Holy <oholy@redhat.com>.
https://bugzilla.gnome.org/show_bug.cgi?id=773925
|
|
|
|
|
|
|
|
| |
Mount entry might not be found e.g. for bind mounts, btrfs subvolumes.
Let's assume that the home trash is on filesystem with trusted
notifications.
https://bugzilla.gnome.org/show_bug.cgi?id=747540
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The default appears to be to translate all entries. This rule never takes
effect, the path to /action/message and /action/description is wrong (/action
is not a root node). Since we wanted them to be translated, it doesn't matter.
But it also translates all other tags (vendor, allow_any, etc.) and that
causes polkit to be unhappy, it can't handle the various language versions of
"no"
** (polkitd:27434): WARNING **: Unknown PolkitImplicitAuthorization string
'tidak'
Switch to a default of "no" and explicitly include the message and description
strings to be translated.
https://bugzilla.gnome.org/show_bug.cgi?id=768707
|
|
|
|
|
|
|
|
|
|
| |
Now that libusb 1.0.21 is finally out, there is a way to explicitly
interrupt a thread that is waiting for events. This allows us to
use a long timeout on our event waiting, which we can interrupt,
rather than a short, one second, timeout. The only nuance is that
we need to link against libusb directly to be able to use the
interrupt mechanism. This is a little bit ugly, but is necessary
unless libmtp wraps the interruption call.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The smb read call can take any arbitrary size and the both the
libsmbclient SMB1 and SMB2 engines will break this down into as
many simultaneous on the wire calls as needed to pipeline
the reads / writes.
Restricting this to 65534 will be slow, so remove this
restriction.
See https://lists.samba.org/archive/samba/2016-October/204225.html
https://bugzilla.gnome.org/show_bug.cgi?id=773632
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"aborted" flag is not returned consistently from the following functions
if the async reply containes an error: g_mount_source_show_processes,
g_mount_source_ask_question, and g_mount_source_ask_password. Set "aborted"
always on TRUE if an error occurs.
This change should not affect current functionality, because the usual
workflow is the following:
if (!g_mount_source_ask_password (..., &aborted, ...) || aborted) ...
https://bugzilla.gnome.org/show_bug.cgi?id=747412
|
|
|
|
|
|
| |
GSimpleAsyncResult is deprecated in favour of GTask and should be replaced.
https://bugzilla.gnome.org/show_bug.cgi?id=747412
|
|
|
|
|
|
|
|
|
|
| |
GSimpleAsyncResult is deprecated in favour of GTask and should be replaced.
This commit also slightly changes API to be more similiar with gdeamonfile.
Based on patch from Dan Winship.
https://bugzilla.gnome.org/show_bug.cgi?id=747412
|
|
|
|
|
|
|
|
| |
GSimpleAsyncResult is deprecated in favour of GTask and should be replaced.
Based on patch from Dan Winship.
https://bugzilla.gnome.org/show_bug.cgi?id=747412
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
GSimpleAsyncResult is deprecated in favour of GTask and should be replaced.
https://bugzilla.gnome.org/show_bug.cgi?id=747412
|
|
|
|
|
|
| |
GSimpleAsyncResult is deprecated in favour of GTask and should be replaced.
https://bugzilla.gnome.org/show_bug.cgi?id=747412
|