summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Update NEWS for 1.41.3 release1.41.3Ondrej Holy2019-06-191-0/+10
|
* gvfsdaemon: Only accept EXTERNAL authenticationSimon McVittie2019-06-061-0/+17
| | | | | | | | | | EXTERNAL is the mechanism recommended in the D-Bus Specification for all platforms where it is supported (including Linux, *BSD, Solaris and Hurd), and is the only mechanism allowed by the session or system dbus-daemon in their default configurations. It is considerably simpler than DBUS_COOKIE_SHA1 and relies on fewer assumptions. Signed-off-by: Simon McVittie <smcv@collabora.com>
* gvfsdaemon: Check that the connecting client is the same userSimon McVittie2019-06-061-1/+35
| | | | | | | | Otherwise, an attacker who learns the abstract socket address from netstat(8) or similar could connect to it and issue D-Bus method calls. Signed-off-by: Simon McVittie <smcv@collabora.com>
* admin: Ensure correct ownership when moving to file:// uriOndrej Holy2019-05-311-0/+46
| | | | | | | User and group is not restored properly when moving (or copying with G_FILE_COPY_ALL_METADATA) from admin:// to file://, because it is handled by GIO fallback code, which doesn't run with root permissions. Let's handle this case with pull method to ensure correct ownership.
* admin: Use fsuid to ensure correct file ownershipOndrej Holy2019-05-311-22/+7
| | | | | | | | Files created over admin backend should be owned by root, but they are owned by the user itself. This is because the daemon drops the uid to make dbus connection work. Use fsuid and euid to fix this issue. Closes: https://gitlab.gnome.org/GNOME/gvfs/issues/21
* admin: Allow changing file ownerOndrej Holy2019-05-311-1/+2
| | | | | | | CAP_CHOWN is dropped together with other privilages and thus the backend can't change file owner. This might be probably e.g. in case of copy operation when G_FILE_COPY_ALL_METADATA is used. Let's keep CAP_CHOWN to fix this.
* admin: Add query_info_on_read/write functionalityOndrej Holy2019-05-311-12/+67
| | | | | | | | | | Admin backend doesn't implement query_info_on_read/write which might potentially lead to some race conditions which aren't really wanted especially in case of admin backend. For example, in file_copy_fallback(), g_file_query_info() is used if g_file_input_stream_query_info() is not supported, which in theory means that the info might be obtained from the different file then it is opened. Let's add this missing functionality to prevent this possibility.
* Update Indonesian translationKukuh Syafaat2019-05-221-241/+239
|
* Post release version bumpOndrej Holy2019-05-211-1/+1
|
* Update NEWS for 1.41.2 release1.41.2Ondrej Holy2019-05-211-0/+10
|
* build: Use break in foreach loopwip/oholy/meson-versionIñigo Martínez2019-05-161-1/+4
| | | | | | | | | Since meson 0.49.0, `break` keyword can be used inside loops. This feature has been used to stop when checking functions in headers that makes avoiding loop iterations. [0] http://mesonbuild.com/Release-notes-for-0-49-0.html#foreach-break-and-continue
* build: Take advantage of has_function argumentIñigo Martínez2019-05-161-7/+7
| | | | | | | | | | Since meson 0.50.0, the `find_library` method can be used to verify if the library's headers or functions are present[0]. The `has_function` argument has been used to check the `socketpair` function in the `socket` library. [0] http://mesonbuild.com/Release-notes-for-0-50-0.html#find-library-with-its-headers
* build: Use path strings in include_directoriesIñigo Martínez2019-05-163-3/+3
| | | | | | | | | | Since meson 0.50.0, plain strings can be used rather than include directory objects[0]. Taking advantage of this feature, some include directory objects have been replaced. [0] http://mesonbuild.com/Release-notes-for-0-50-0.html#include_directories-accepts-a-string
* build: Use dictionaries in configuration_data objectsIñigo Martínez2019-05-165-16/+17
| | | | | | | | | | Since 0.49.0[0], a dictionary could be used as a replacement for each key/value pair as if `set` method was called for each of them. Almost all of the `configuration_data` objects have been changed to use a dictionary. [0] http://mesonbuild.com/Reference-manual.html#configuration_data
* build: Bump required meson version to 0.50.0Ondrej Holy2019-05-161-1/+1
| | | | | | | | | | | We are obviously using features from meson 0.50.0 as per the following warnings: WARNING: Project targetting '>= 0.49.0' but tried to use feature introduced in '0.50.0': install arg in configure_file So let's bump the required version in order to prevent those warnings.
* google: Support deleting shared Google Drive filesMayank Sharma2019-05-091-5/+75
| | | | | | | | | | | | | | | | `g_file_delete ()` currently fails for shared files with "Permission denied" error (if they have a different owner and only one parent folder). This is because `gdata_service_delete_entry ()` can't be used for files, which have a different owner. `gdata_documents_service_remove_entry_from_folder ()` has to be used instead in this case (as well as for cases when the files have multiple parents). This fix depends on https://gitlab.gnome.org/GNOME/libgdata/merge_requests/5, which fixes `gdata_documents_service_remove_entry_from_folder ()` implementation to make it work for files with only one parent. Fixes: https://gitlab.gnome.org/GNOME/gvfs/issues/265
* Update Chinese (China) translationDz Chen2019-05-081-1674/+1412
|
* admin: Handle --help even if not under pkexecOndrej Holy2019-04-301-12/+12
| | | | | Error is shown if `gvfsd-admin --help` is started without pkexec. Change order of the input checks and print help in this case as well.
* admin: Prevent core dumps when daemon is manually startedOndrej Holy2019-04-301-2/+9
| | | | | | | | Use `g_printerr ()` instead of `g_error ()` in order to prevent core dumps when starting the gvfsd-admin daemon manually without pkexec, or with wrong commandline arguments. Fixes: https://gitlab.gnome.org/GNOME/gvfs/issues/395
* admin: Fix minor memory leakOndrej Holy2019-04-301-1/+1
| | | | | GOptionContext is not released after `g_option_context_new ()` call. Let's use `g_option_context_free ()` to fix this minor memory leak.
* afc: Remove assumptions about length of device UUIDPhilip Langdale2019-04-291-11/+5
| | | | | | | | | | | Modern Apple devices have UUIDs that are not 40 digits long, as used to be the case. Accordingly, a recent change in libimobiledevice removed any assumptions around the UUID length, and we should do the same in the afc backend. Without this change, we see a symptom where the volume monitor and backend disagree on the expected mount root. I have tested this on a 2018 iPad pro (iPad8,3) which has a 24 digit UUID.
* Post release version bumpOndrej Holy2019-04-231-1/+1
|
* Update NEWS for 1.41.1 release1.41.1Ondrej Holy2019-04-231-0/+8
|
* gmountsource: Fix deadlocks in synchronous APIwip/oholy/gmountsource-deadlockOndrej Holy2019-04-091-39/+29
| | | | | | | | | | | | Synchronous GMountSource API is implemented using the asynchronous API with help of mutexes and conditions. But it seems that it is not guaranteed that GAsyncReadyCallback is called on another thread and thus this solution may cause deadlocks consequently. Let's rather use solution based on custom mainloop to prevent potential deadlocks. Alternatively, we could use synchronous API generated by gdbus-codegen to implement this functionality, but the solution with custom mainloop seems to be less error-prone. Closes: https://gitlab.gnome.org/GNOME/gvfs/issues/383
* fuse: Adapt gvfsd-fuse to use fuse 3.xXi Ruoyao2019-04-044-38/+84
| | | | | | | | | | Gvfsd-fuse required the old 2.x versions of fuse. Fuse developers encourage developers to transition to the actively developed libfuse 3.x. This change adapt gvfsd-fuse to build with fuse 3.x. Note that fuse is no longer compatible with fuse 2.x. It now requires fuse 3.0.0 or later to build. Closes: https://gitlab.gnome.org/GNOME/gvfs/issues/323
* afp: Fix afp backend crash when no username suppliedMayank Sharma2019-03-281-0/+6
| | | | | | | | A missing NULL check in g_vfs_afp_command_put_pascal caused crashes (seg faults) when no username was given. Crashes happened irrespective of Password was given or not. https://gitlab.gnome.org/GNOME/gvfs/issues/298
* Update Croatian translationGoran Vidović2019-03-261-379/+380
| | | | (cherry picked from commit 278ce739649f2580f9cb767b00a5e7cc4143697a)
* daemon: Use "No such file or directory" consistentlyMayank Sharma2019-03-211-1/+1
| | | | | | | GVfs uses different forms of "No such file or directory", e.g. "No such file or directory in target path". Hence, unify them. https://gitlab.gnome.org/GNOME/gvfs/issues/170
* daemon: Use "Backups not supported" consistentlyMayank Sharma2019-03-213-5/+5
| | | | | | | | | GVfs uses different forms of "Backups not supported" string, e.g. "Backups are not yet supported.", "backups not supported" and "backups not supported yet". Let's use "Backups not supported" consistently. https://gitlab.gnome.org/GNOME/gvfs/issues/170
* daemon: Use "Operation not supported" consistentlyMayank Sharma2019-03-2145-85/+85
| | | | | | | | | GVfs uses different forms of "Operation not supported" string, e.g. "Operation unsupported", "Operation not supported by backend". Let's use "Operation not supported" consistently as this is also used in GLib. https://gitlab.gnome.org/GNOME/gvfs/issues/170
* Post branch version bumpOndrej Holy2019-03-211-1/+1
|
* Post release version bumpOndrej Holy2019-03-111-1/+1
|
* Update NEWS for 1.40.0 release1.40.0Ondrej Holy2019-03-111-1/+5
|
* ci: Update image and versions for gnome-build-meta jobOndrej Holy2019-03-051-3/+8
| | | | | Reflect the changes made in GNOME/gnome-build-meta!226 to make the job work again.
* Post release version bumpOndrej Holy2019-03-041-1/+1
|
* Update NEWS for 1.39.92 release1.39.92Ondrej Holy2019-03-041-0/+6
|
* client: Fix mount info cache invalidationOndrej Holy2019-03-042-28/+30
| | | | | | | | | | | | | Mount info cache invalidation is not handled properly and thus client can get "Cache invalid, retry (internally handled)" internal error, which should not be passed to the client. This can happen if mount was unmounted and another mount for the some location is mounted. This is now more common with introducing stable URIs for MTP backend. G_VFS_ERROR_RETRY error handling was probably lost as a consequence of GDBus port by commit 622a5c0d. Let's retry the operation internally again if G_VFS_ERROR_RETRY is returned. https://gitlab.gnome.org/GNOME/gvfs/merge_requests/30
* Update Latvian translationRūdolfs Mazurs2019-03-031-327/+324
|
* Updated Vietnamese translationTrần Ngọc Quân2019-03-031-245/+248
| | | | Signed-off-by: Trần Ngọc Quân <vnwildman@gmail.com>
* Update Serbian translationМарко Костић2019-02-281-145/+149
|
* Update Russian translationStas Solovey2019-02-271-149/+152
|
* Update German translationTim Sabsch2019-02-261-323/+324
|
* Update Korean translationChangwoo Ryu2019-02-261-325/+324
|
* sftp: Improve debug output of ssh cmdlineOndrej Holy2019-02-261-3/+9
| | | | | | | | | | | Currently, the debug output of ssh cmdline looks like: sftp: spawn_ssh: sftp: /usr/bin/ssh sftp: -oForwardX11 no sftp: -oForwardAgent no sftp: -oPermitLocalCommand no sftp: -oClearAllForwardings yes sftp: -oProtocol 2 sftp: -oNoHostAuthenticationForLocalhost yes sftp: -p sftp: 22222 sftp: -s sftp: 10.220.47.158 sftp: sftp sftp: This is because we add prefixes for each g_debug, which makes this unreadable. Let's concatenate the strings before printing over g_debug.
* test: Remove trailing newline from the IP stringOndrej Holy2019-02-261-1/+2
| | | | | | | | test_unknown_host uses the following URI: sftp://10.220.47.158%0A:22222/. It contains %0A (newline character), which makes it invalid and may cause problems. Let's remove the trailing newline from the IP to make it valid. https://gitlab.gnome.org/GNOME/gvfs/issues/376
* Update Dutch translationNathan Follens2019-02-241-538/+549
|
* Update Italian translationMilo Casagrande2019-02-221-324/+325
|
* Update Brazilian Portuguese translationRafael Fontenelle2019-02-211-331/+329
|
* Post release version bumpOndrej Holy2019-02-181-1/+1
|
* Update NEWS for 1.39.91 release1.39.91Ondrej Holy2019-02-181-0/+6
|