| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
Currently g_errprint is used and thus a message doesn't end up in a logs.
Use g_warning to log the message and also replace g_return_if_fail,
because proxy creation failure isn't programmer error.
https://bugzilla.gnome.org/show_bug.cgi?id=755805
|
|
|
|
|
|
|
| |
Accesses to the drives, volumes and mounts hash tables should be
guarded by the proxy_vm mutex.
https://bugzilla.gnome.org/show_bug.cgi?id=755805
|
|
|
|
|
|
|
|
| |
When using "systemd --user" in conjunction with "dbus-daemon --session
--systemd-activation", this ensures that each daemon is correctly placed
in its own cgroup, instead of being treated as part of dbus.service.
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=755760
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This naming is mandatory for the system bus, but is also recommended
for the session bus.
The D-Bus maintainers recommend that all activatable session services'
service files are named according to the bus name, so that any conflict
is resolved in a deterministic way. If the services are in different
directories (precedence levels) the result is the same as it is now:
the higher precedence "wins". If the services are in the same
directory, either one overwrites the other and consistently "wins",
or a packaging system like dpkg prevents co-installation.
If the service files were named differently, it would be possible
to have two implementations for the same name. dbus-daemon resolves
this by choosing one arbitrarily, not necessarily the same one every
time. systemd's kdbus support is more strict (or less concerned with
backwards compatibility), and treats this situation as an error.
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=755760
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
g_file_monitor_file() is a sync call anyway, so doing some sync i/o
in the constructor doesn't make a difference, and doing so avoids
races where you would not get change events for operations you do.
We don't actually need to wait for the subscribe event, and proxy
construction in this case does not do any i/o, so we're really only
doing sync i/o to look up the connection, and it should be cached from
the earlier call in g_daemon_file_monitor_file(), so in practice
this should make little difference.
https://bugzilla.gnome.org/show_bug.cgi?id=749317
|
|
|
|
|
|
|
|
|
|
| |
Progress isn't reported currently. However it is guaranteed that
the progress callback will be called at least after all data has
been transferred according the GIO documentation. Nautilus shows
some weird progress info when moving and copying consequently. Emit
progress callback with total size to fix this issue.
https://bugzilla.gnome.org/show_bug.cgi?id=755775
|
|
|
|
|
|
|
|
|
|
|
|
| |
The existing code sanitizes relative symlinks but not absolute symlinks
when resolving them. But this can cause issues when looking up the
resolved path (e.g. if it has a trailing slash, the correct information
will not be returned because it will not get the parent directory
correctly).
To fix this, sanitize both absolute and relative paths.
https://bugzilla.gnome.org/show_bug.cgi?id=755303
|
|
|
|
| |
Signed-off-by: Trần Ngọc Quân <vnwildman@gmail.com>
|
| |
|
|
|
|
|
|
| |
Otherwise nautilus will offer the wrong action in its UI.
https://bugzilla.gnome.org/show_bug.cgi?id=753934
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the remote connection(s) are closed (e.g. the remote host is
rebooted), ensure that g_vfs_backend_force_unmount is only called once.
This avoids a warning like the following:
forced_unregister_mount_callback
forced_unregister_mount_callback
** (process:12472): WARNING **: Error unregistering mount: Mountpoint
not registered (g-io-error-quark, 16)
Additionally, remove some backend member variables.
https://bugzilla.gnome.org/show_bug.cgi?id=753311
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
destroy_connection() is called twice when setup of data connection failed.
Consequently g_hash_table_destroy() is called on already destroyed hash
table on finalize. Set conn->expected_replies to NULL in destroy_connection()
to fix the issue.
There is another crash on force unmount when setup of data connection failed.
fail_jobs() is called on already destroyed connection. Check usability of
the connection before use to avoid the crash.
Finally move the hast table initialization into the setup_connection,
because the initialization in g_vfs_backend_sftp_init() is confusing.
https://bugzilla.gnome.org/show_bug.cgi?id=753311
|
|
|
|
|
|
|
|
| |
Unify send_reply debug messages for all jobs. Always indicate failure
and include error message. Indicate some other info (i.e. offset,
size) for some jobs (i.e. seek, read, write).
https://bugzilla.gnome.org/show_bug.cgi?id=755104
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=754791
|
|
|
|
|
|
|
| |
Commit 59325df refactored daemon code a bit. Function do_name_acquired
is no more needed. Remove this function to avoid following warnings:
daemon-main.c:347:1: warning: ‘do_name_acquired’ defined but not used
|
| |
|
| |
|
| |
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=753838
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=754729
|
|
|
|
|
|
| |
Based on code written by Thibault Saunier.
https://bugzilla.gnome.org/show_bug.cgi?id=739008
|
|
|
|
|
|
|
| |
The Google Drive backend would be OAuth2-based, so we should include
such accounts too.
https://bugzilla.gnome.org/show_bug.cgi?id=739008
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows you to easily allow access to gvfs from a sandbox.
Just give it talk access to org.gtk.vfs.* and everything will work.
This change does three things:
Change the existing mountpoint dbus names from
org.gtk.vfs.mountpoint.foo
to
org.gtk.vfs.mountpoint_foo
For other mountpoints, always own:
org.gtk.vfs.mountpoint_$pid
Change the dbus name of the volume monitors from
org.gtk.Private.fooMonitor
to
org.gtk.vfs.fooMonitor
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
After commit a807f12d5663 ("MTP: return ENOTEMPTY if trying to delete a
non-empty directory"), G_IO_ERROR_NOT_EMPTY is returned if a generic
error occurs when deleting. Fix it by calling fail_job() as the rest of
the code does.
https://bugzilla.gnome.org/show_bug.cgi?id=753590
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Use g_warning rather than g_error when a read error occurs to prevent
spurious crash reports since there are many different ways for a read
from the network to fail.
[Cherry-picked from gnome-3-14/14369db2a8fc
Commit message written by Ross Lagerwall.]
https://bugzilla.gnome.org/show_bug.cgi?id=710490
|
| |
|