| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
|
|
|
|
| |
The file_transfer function contains a statement ensuring that the operation
fails when files are on different mounts. But this statement is never reached.
This case is correctly handled inside the create_proxy_for_file2 functio. Let's
remove the dead code.
|
|
|
|
|
|
|
|
| |
When the push method in DAV baclend is called with a nonexistent source
file, the `GLib-GObject-CRITICAL **: 12:07:04.743: g_object_unref:
assertion 'G_IS_OBJECT (object)' failed` message is printed because
the `g_object_unref` function is called for a `NULL` pointer. Let's
use `g_clear_object` instead to avoid this.
|
|
|
|
|
|
|
|
|
| |
The push/pull methods rely on local paths. This is a problem for Flatpak
applications because the GVfs daemons run outside of it, so the same local
path might refer to a different file. Let's disable the push/pull methods
for Flatpak applications to fix errors when moving/copying.
Related: https://github.com/flathub/org.libreoffice.LibreOffice/issues/23
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, using `FileProgressCallback` is quite confusing as
`current_num_bytes` is in uncompressed bytes unlike `total_num_bytes`
which is in compressed bytes.
In order to solve this issue, we disable compression in `query_info` by
setting the "Accept-Encoding" flag to `identity` (none). Then whenever
`query_info_on_read` is called, we make sure that the request wasn't set
to accept compresssion and fallback to `query_info` if it is the case.
Fixes #195
|
|
|
|
|
|
|
|
| |
In several places, the code compares to strings by comparing
their pointers instead of using g_strcmp0(). Although this
seems to work, it is incorrect.
This MR fixes it.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
When the username is not part of an URI, then the following message is
printed: `GVFS-CRITICAL **: 12:31:47.663: g_mount_spec_set_with_len_internal:
assertion 'value != NULL' failed`. This is because `g_mount_spec_set` is
called with `NULL`. It possibly lead to crash when it is build with the
`G_DISABLE_CHECKS` option. This bug was introduced recently by the commit
6636d89f. Let's check the value before setting it to fix this.
Related: https://gitlab.gnome.org/GNOME/gvfs/-/issues/644
|
| |
|
|
|
|
|
|
|
|
|
|
| |
After gvfsd-ftp is connected to the ftp server, if the ftp server
stops, the gvfsd-ftp sending request will be stuck, even after the ftp
server is started, it still cannot be recovered. This is because
ftp->connections is not updated when the connection is released,Thus
let ftp->connections decrement by one when the connection is released.
https://gitlab.gnome.org/GNOME/gvfs/-/merge_requests/149
|
|
|
|
|
|
|
|
| |
When the file fails to open, vfs_release() will not be called, which
makes the file handle unable to be released, which will cause subsequent
creation of the same name file to fail.
Related: https://gitlab.gnome.org/GNOME/gvfs/-/issues/660
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Meson is currently configured to search the gvfs builder's PATH for an
ssh client, and hardcode its fullpath as the canonical ssh client for
the gvfs sftp backend.
This setup breaks in cases where the builder has a different ssh client
from the final runtime root, or where the client's pathes differ.
Builders using OpenEmbedded or buildroot workspaces are particularly
affected.
Instead, set SSH_PROGRAM to `ssh` so that it gets PATH-expanded at
runtime.
Closes: https://gitlab.gnome.org/GNOME/gvfs/-/issues/465
Signed-off-by: Alex Stewart <alex.stewart@ni.com>
|
|
|
|
|
| |
The action is done asynchronous by the service and without the delay
the trash is sometime showing empty when it shouldn't.
|
|
|
|
|
| |
The option has been deprecated in udisks for years and is just displaying
a warning in the log
|
|
|
|
|
|
|
|
|
| |
GVfs doesn't support x-large and xx-large thumbnails currently. Consequently,
thumbnails are not shown for remote locations in Nautilus on HiDPI screens.
GLib added support for them over glib!2941 recently. Let's do the similar
change for GVfs.
Relates: glib#2767
|
|
|
|
| |
(cherry picked from commit da9b31e0310bd917773f30cdbf3626c5b9c04ea1)
|
| |
|
|
|
|
|
| |
GNOME mailing lists and IRC are retired. Let's refer people to GNOME Discourse
instead.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
To make it easier to add new ones without changing a whole line.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
When on WiFi, the NextCloud account is automatically mounted after
resuming from suspension. This is because the `Account.AttentionNeeded`
property changes its value and GOA volume monitor calls mount operation
in that case. It is not obvious to me why this code is here. Also this
is maybe bug on GOA side. But anyway, other backends simply just unmount
when something changes, but don't mount again automatically. I suppose we
should do the same here as well to avoid these unwanted automounts.
Fixes: https://gitlab.gnome.org/GNOME/gvfs/-/issues/634
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
The `mount_try_again` variable is redundant since it is set to `TRUE` in
all cases. Let's remove it to sligtly improve readability of the code.
|
|
|
|
|
|
|
|
|
|
|
| |
After the recent samba change, the "Invalid Argument" error can be still
returned when anonymous login is requested even after the commit 747c7f6.
This is because `smbc_setOptionNoAutoAnonymousLogin` is called after returning
from the `auth_callback` function (i.e. there is one redundant iteration).
Let's rework the handling a bit and call that immediately, which bypasses
the issue.
Fixes: https://gitlab.gnome.org/GNOME/gvfs/-/issues/619
|
|
|
|
|
|
|
|
|
|
| |
Currently, the HTTP backend fails with the "The specified location is
not mounted" error for URIs with path containing escaped characters.
This is because the mount prefix is not unescaped. This is unfortunatelly
another libsoup3 port regression. Let's correctly unescape the prefix to
make that work again.
Fixes: https://gitlab.gnome.org/GNOME/gvfs/-/issues/623
|
|
|
|
|
|
|
|
|
| |
The recent commits break build when Avahi support is disabled. Let's add
the missing ifdef directive and move some variable declarations to fix
the build. Part of this change was originally proposed by the reporter of
GNOME/gvfs#621.
Fixes: https://gitlab.gnome.org/GNOME/gvfs/-/issues/621
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, it is not possible to connect to some Nextcloud servers when
a username is part of URI. So this also affects volumes configured over
GOA. The main problem seems to be that Nextcloud doesn't send the
`WWW-Authenticate` header as a part of 401 response in certain cases (e.g.
when 2FA is enabled). A recent libsoup change leads to the situation that
DAV backend doesn't have a chance to specify a password as the `authenticate`
signal is not called at all. This is because libsoup tries to authenticate
with an empty password first. Let's drop the username from URI to avoid the
password-less login attempt so the backend has at least one chance to try
some password in this case...
Fixes: https://gitlab.gnome.org/GNOME/gvfs/-/issues/617
|
|
|
|
|
|
|
|
|
|
| |
The mount operation hangs for DNS-SD style URIs (i.e. with `dav+sd` and
`davs+sd` schemes) after the recent commit 9203fad5. This is because the
backend now uses the asynchronous APIs, but the `GVfsDnsSdResolver` is still
used synchronously. Let's use asynchronous API for the resolver as well to
fix the hangs.
Fixes: https://gitlab.gnome.org/GNOME/gvfs/-/issues/618
|
|
|
|
|
|
|
|
| |
With samba 4.16.0, mount operation fails with the "Invalid Argument" error
when kerberos/ccache is misconfigured. Ignore this error, so user get a chance
to login using the password...
Fixes: https://gitlab.gnome.org/GNOME/gvfs/-/issues/611
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since libsoup3 cannot deal with threads, we cannot use the do_
methods which execute in a thread pool. However, we can implement
these in an async manner, which will bypass the thread pool and
get rid of the issue.
The write methods are left synchronous as they deal with a memory
output stream and do not actually call libsoup. Therefore, we do
not have to care whether they are threaded or not.
Fixes: https://gitlab.gnome.org/GNOME/gvfs/-/issues/609
|
|
|
|
|
|
|
|
|
|
| |
The use of g_uri_build was also bad, since otherwise we would
run into this: https://gitlab.gnome.org/GNOME/glib/-/issues/2619
While this should be fixed in glib, we need to work around this
behavior for existing installations.
Fixes: https://gitlab.gnome.org/GNOME/gvfs/-/issues/614
|
|
|
|
|
|
|
|
|
| |
The `mount_base` uri is unreffed twice. First time over the local `mount_base`
pointer and for the second time over the `G_VFS_BACKEND_HTTP (backend)->mount_base`
pointer. This leads to `SIGABRT` from the `__pthread_kill_implementation`
function. Let's remove that extra unref to fix this crashes.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2066717
|