| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
| |
The security-related issues should be reported over
https://security.gnome.org/ currently. Let's replace the obsolete
security@gnome.org e-mail address.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The layout of the modal dialogs in gnome-shell changed [1] and the title
now is larger and uses the style of a headline. Make sure all titles
remain fully visible and use shorter strings for those.
Also unify the generic "Enter password" strings a bit to make work
easier for translators and use this string for most cases:
"Authentication Required\nEnter password for “%s”:"
[1] https://gitlab.gnome.org/GNOME/gnome-shell/issues/1343
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Recently added warnings when peer-to-peer connection fails (commit 60ca0cea)
makes visible old bug that the session bus fallback is tried regardless of
the fact that the operation was cancelled. Let's stop the operation
immediately when G_IO_ERROR_CANCELLED is returned and don't print the
warnings in this case.
|
|
|
|
|
|
|
|
| |
gphoto2 does this since commit 983186766060ec82e260f8cd9a5160b93b2ae958
The same rationale applies to MTP.
https://gitlab.gnome.org/GNOME/gvfs/-/issues/497
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The MTP spec section 5.2.2.7 allows `StorageDescription` to be
an empty string.
`libmtp` currently translates this to
char * StorageDescription = NULL
instead of `""` in `ptp_unpack_SI()` via `ptp_unpack_string()`.
(I'm not sure if it's good that it does that, to be followed up on separately.)
`create_storage_name()` until now returned
`g_strdup(storage->StorageDescription)`, which returns `NULL` if `NULL` is
given, and thus `get_storage_info()` would eventually call
char *storage_name = NULL = create_storage_name(storage);
g_file_info_set_name (info, storage_name = NULL);
g_file_info_set_display_name (info, storage_name = NULL);
resulting in assertion failures in `gvfsd`:
g_file_info_set_name: assertion 'name != NULL' failed
g_file_info_set_display_name: assertion 'display_name != NULL' failed
as well as crashes in file managers like Thunar:
g_file_get_child: assertion 'name != NULL' failed
and warnings in Nautilus like:
Got GFileInfo with NULL name in mtp://Ricoh_Company__Ltd._RICOH_THETA_V_00165759/, ignoring. This shouldn't happen unless the gvfs backend is broken.
This commit fixes it by adding a contract to `create_storage_name()`
that it will never represent empty strings as NULL.
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
It seems that if file monitor is not canceled before unreffing, it can
cause deadlock. Let's explicitly cancel it before unreffing to prevent
this. See https://gitlab.gnome.org/GNOME/glib/-/issues/1941.
Fixes: https://gitlab.gnome.org/GNOME/gvfs/-/issues/485
|
|
|
|
|
|
|
|
| |
Copying file from file:// to admin:// is slow. This is because push
vfunc is not implemented and thus read-write fallback is used. Let's
implement push to improve performance in this case as well.
https://gitlab.gnome.org/GNOME/gvfs/-/issues/530
|
|
|
|
|
|
|
|
| |
Copying file within admin backend is slow in comparison to file://.
This is because copy vfunc is not implemented and thus read-write
fallback is used. Let's implement native copy to improve performance.
Fixes: https://gitlab.gnome.org/GNOME/gvfs/-/issues/530
|
|
|
|
|
|
| |
Asynchronous API fallbacks to session bus when peer-to-peer connection
fails, however, synchronous API fails in the same case. Let's add
fallback to session bus also for the synchronous case.
|
|
|
|
|
|
|
| |
When peer-to-peer connection fails, the session bus is silently used
instead by the asynchronous API. Let's add warnings to make it more
obvious and mention that --filesystem=xdg-run/gvfsd is probably
missing.
|
|
|
|
|
|
| |
g_vfs_icon_load_async fails if peer-to-peer connection can't be
establised. Let's add fallback to session bus as it is implemented
already on other places.
|
|
|
|
|
|
|
|
|
|
| |
Flatpak applications don't work with gvfs if network access is not
granted. This is because GVfs for peer-to-peer communication uses
abstract sockets, which are tied to the network namespace. Let's use
named sockets under /run/user/$UID/gvfsd/ instead, which will allow
applications to use --filesystem=xdg-run/gvfsd to grant access.
Fixes: https://gitlab.gnome.org/GNOME/gvfs/-/issues/515
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
The G_FILE_ATTRIBUTE_STANDARD_FAST_CONTENT_TYPE attribute is currently
set only if the G_FILE_ATTRIBUTE_STANDARD_CONTENT_TYPE or some other
attributes are requested. Thus it is not set when the fast content type
attribute is requested separately. Let's set the attribute independently
to fix this issue.
Fixes: https://gitlab.gnome.org/GNOME/gvfs/-/issues/529
|
|
|
|
| |
(cherry picked from commit 22c1d06816f83b1b422f4b456d4a8a6e2e3c24bd)
|
| |
|
|
|
|
|
|
| |
When moving file from FTP to local filesystem, the remote file is removed
regradless of transfer failure. This is pretty bad as it might lead to data
loss. Let's delete the remote file only if the transfer suceeded.
|
|
|
|
|
|
| |
The output stream is not properly closed in pull job, which might potentially
lead to data loss. Let's use the recently added splice function and close the
output stream with the help of G_OUTPUT_STREAM_SPLICE_CLOSE_TARGET flag.
|
|
|
|
|
|
|
|
|
| |
Google backend doesn't report progress from push job. As a consequence,
Nautilus shows wierd time estimations when moving/copying file from
local filesystem. Let's add custom splice function and report progress
from it.
Fixes: https://gitlab.gnome.org/GNOME/gvfs/-/issues/463
|
|
|
|
|
|
| |
Meson finally provides official function to print configuration summary
since version 0.53.0. Let's use it instead of custom output to be a bit
more consistent with other projects.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Currently, SFTP backend timeouts when two factor authentication is used
as it doesn't expect another prompt. Let's handle "Verification code"
and "One-time password" prompts and ask user to enter the code.
Fixes: https://gitlab.gnome.org/GNOME/gvfs/-/issues/480
|