| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
| |
Currently, the mount operation for the admin backend can hang when the
authentication dialog is dismissed for example. This is because `pkexec`
exits before spawning the `gvfsd-admin` daemon. Let's catch that case
and return the "Permission denied" error.
Fixes: https://gitlab.gnome.org/GNOME/gvfs/-/issues/565
|
| |
|
|
|
|
|
|
|
| |
Currently, `wheel` group is hardcoded in the `.rules` file which is there
to prevent redundant password prompt when starting gvfsd-admin. The Debian
based systems obviously uses `sudo` group instead of `wheel`. Let's make
the privileged group configurable.
https://gitlab.gnome.org/GNOME/gvfs/-/issues/565
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
When installing gvfs into a prefix (like in jhbuild), we need to pass
`gvfs_prefix` to meson's `get_pkgconfig_variable` to make sure that
systemd unit files are installed to the installation prefix, instead of
systemd's prefix (which will likely be your system's /usr).
See: https://github.com/systemd/systemd/issues/18082
See: https://github.com/systemd/systemd/commit/1c2c7c6cb3d92315624f3711114e86b0acfbce63
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
GVfs fallbacks to session bus if it is not possible to establish
peer-to-peer connection (e.g. inside Flatpak sandbox). However,
the DBus server is not terminated and the socket is leaked. The
named sockets are counted as open files, so it can easily lead to
"Too many open files" errors. Let's fallback to the session bus
immediately if the socket dir is not accessible to prevent the
leaks. This should fix the most common case, when the sockets are
leaked.
Fixes: https://gitlab.gnome.org/GNOME/gvfs/-/issues/542
|
| |
|
|
|
|
|
|
|
| |
Currently, critical errors are printed when peer credentials aren't
available (i.e. session bus fallback is used). Let's return an error
immediately to prevent the criticals. Also add warning with suggestion
to allow `--filesystem=xdg-run/gvfsd` access.
https://gitlab.gnome.org/GNOME/gvfs/-/issues/305
|
| |
|
|
|
|
|
|
|
|
|
| |
Recently, GVfs switched from abstract sockets to named sockets. The
sockets are created in the `XDG_RUNTIME_DIR` directory. This directory
is not unfortunatelly set for `gvfsd-admin` and thus the root's cache
dir is used instead, which is wrong. Let's pass the `XDG_RUNTIME_DIR`
environment variable to the `pkexec` environment similarly to
`DBUS_SESSION_BUS_ADDRESS`.
Fixes: https://gitlab.gnome.org/GNOME/gvfs/-/issues/552
|
| |
|
|
|
|
|
|
|
|
| |
Recently, GVfs switched from abstract sockets to named sockets. The
named sockets honors file permissions and thus the socket owner is root
in the case `gvfsd-admin`. This obviously prevents client from connecting.
Let's change the owner to the value of `PKEXEC_UID` to ensure that the
socket is usable by the client.
https://gitlab.gnome.org/GNOME/gvfs/-/issues/552
|
| |
|
|
|
|
|
|
|
|
|
| |
Recently, GVfs switched from abstract sockets to named sockets. The
socket dir is currently created by the individual daemons immediately
before starting DBus server. If gvfsd-admin is started at first, the
socket dir is owned by root user and thus it isn't accesible for other
daemons and clients. Let's create the socket dir early from the gvfsd
daemon to ensure correct ownership.
https://gitlab.gnome.org/GNOME/gvfs/-/issues/552
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
| |
The DAV test cases sometimes fails with "(98)Address already in use:
AH00072: make_sock: could not bind to address 127.0.0.1:8088". This
seems to happen only on runners which don't have ipv6 tag. Let's
temporarily add the tag to fix those failures. It would be best to
programmatically try some range of ports, but this is currently out
of my time resources.
|
| |
|
|
|
|
|
|
|
|
| |
The naming scheme for the non-abstract socket was changed but
`new_connection_data_free` was not adjusted to match.
`GDBusServer` will remove the socket when it stops, but only if
`g_dbus_server_start` was called. So we can simplify the process
somewhat. Also don't bother removing the directory now that all sockets
share it.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The "show-unmount-progress" signal isn't emitted when unmounting
is successful while the "show-processes" dialog is open.
The "aborted" signal is sent to close the dialog, not to indicate
an error, and shouldn't be taken into consideration when deciding
whether to emit "show-unmount-progress". Further details on the
bug report.
Get gvfs_udisks2_unmount_notify_stop() to send
"show-unmount-progress" whether there was a prior "aborted" or not.
Closes https://gitlab.gnome.org/GNOME/gvfs/-/issues/546
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
The comment in the .rules file contains `another prompts` phrase which is
wrong. Let's use `another prompt` instead of it.
|
