| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Closes: #639
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
When on WiFi, the NextCloud account is automatically mounted after
resuming from suspension. This is because the `Account.AttentionNeeded`
property changes its value and GOA volume monitor calls mount operation
in that case. It is not obvious to me why this code is here. Also this
is maybe bug on GOA side. But anyway, other backends simply just unmount
when something changes, but don't mount again automatically. I suppose we
should do the same here as well to avoid these unwanted automounts.
Fixes: https://gitlab.gnome.org/GNOME/gvfs/-/issues/634
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
The `mount_try_again` variable is redundant since it is set to `TRUE` in
all cases. Let's remove it to sligtly improve readability of the code.
|
|
|
|
|
|
|
|
|
|
|
| |
After the recent samba change, the "Invalid Argument" error can be still
returned when anonymous login is requested even after the commit 747c7f6.
This is because `smbc_setOptionNoAutoAnonymousLogin` is called after returning
from the `auth_callback` function (i.e. there is one redundant iteration).
Let's rework the handling a bit and call that immediately, which bypasses
the issue.
Fixes: https://gitlab.gnome.org/GNOME/gvfs/-/issues/619
|
|
|
|
|
|
|
|
|
|
| |
Currently, the HTTP backend fails with the "The specified location is
not mounted" error for URIs with path containing escaped characters.
This is because the mount prefix is not unescaped. This is unfortunatelly
another libsoup3 port regression. Let's correctly unescape the prefix to
make that work again.
Fixes: https://gitlab.gnome.org/GNOME/gvfs/-/issues/623
|
|
|
|
|
|
|
|
|
| |
The recent commits break build when Avahi support is disabled. Let's add
the missing ifdef directive and move some variable declarations to fix
the build. Part of this change was originally proposed by the reporter of
GNOME/gvfs#621.
Fixes: https://gitlab.gnome.org/GNOME/gvfs/-/issues/621
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, it is not possible to connect to some Nextcloud servers when
a username is part of URI. So this also affects volumes configured over
GOA. The main problem seems to be that Nextcloud doesn't send the
`WWW-Authenticate` header as a part of 401 response in certain cases (e.g.
when 2FA is enabled). A recent libsoup change leads to the situation that
DAV backend doesn't have a chance to specify a password as the `authenticate`
signal is not called at all. This is because libsoup tries to authenticate
with an empty password first. Let's drop the username from URI to avoid the
password-less login attempt so the backend has at least one chance to try
some password in this case...
Fixes: https://gitlab.gnome.org/GNOME/gvfs/-/issues/617
|
|
|
|
|
|
|
|
|
|
| |
The mount operation hangs for DNS-SD style URIs (i.e. with `dav+sd` and
`davs+sd` schemes) after the recent commit 9203fad5. This is because the
backend now uses the asynchronous APIs, but the `GVfsDnsSdResolver` is still
used synchronously. Let's use asynchronous API for the resolver as well to
fix the hangs.
Fixes: https://gitlab.gnome.org/GNOME/gvfs/-/issues/618
|
|
|
|
|
|
|
|
| |
With samba 4.16.0, mount operation fails with the "Invalid Argument" error
when kerberos/ccache is misconfigured. Ignore this error, so user get a chance
to login using the password...
Fixes: https://gitlab.gnome.org/GNOME/gvfs/-/issues/611
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since libsoup3 cannot deal with threads, we cannot use the do_
methods which execute in a thread pool. However, we can implement
these in an async manner, which will bypass the thread pool and
get rid of the issue.
The write methods are left synchronous as they deal with a memory
output stream and do not actually call libsoup. Therefore, we do
not have to care whether they are threaded or not.
Fixes: https://gitlab.gnome.org/GNOME/gvfs/-/issues/609
|
|
|
|
|
|
|
|
|
|
| |
The use of g_uri_build was also bad, since otherwise we would
run into this: https://gitlab.gnome.org/GNOME/glib/-/issues/2619
While this should be fixed in glib, we need to work around this
behavior for existing installations.
Fixes: https://gitlab.gnome.org/GNOME/gvfs/-/issues/614
|
|
|
|
|
|
|
|
|
| |
The `mount_base` uri is unreffed twice. First time over the local `mount_base`
pointer and for the second time over the `G_VFS_BACKEND_HTTP (backend)->mount_base`
pointer. This leads to `SIGABRT` from the `__pthread_kill_implementation`
function. Let's remove that extra unref to fix this crashes.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2066717
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The dav and http backends of the daemon now use libsoup3. Things
should work more or less the same as before.
One caveat is that the soup session no longer defaults to
ssl-strict, so it will no longer silently accept certificates.
This does not affect the DAV backend (it has its own handling
which is replicated in the soup3 port) but it does affect the
http backend.
Fixes: https://gitlab.gnome.org/GNOME/gvfs/-/issues/208
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
The positional argument was being silently ignored until meson 0.60.0 where
it fails with "ERROR: Function does not take positional arguments".
Related: https://github.com/mesonbuild/meson/issues/9441
Fixes: https://gitlab.gnome.org/GNOME/gvfs/-/issues/599
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
SFTP backend fails when connecting with the "Timed out when logging in"
error with the recent OpenSSH versions. This is because their password
prompts are now prefixed by the `(user@host)` string, which breaks our
`g_str_has_prefix` checks. Let's use `strstr` instead to fix this issue
and also to not break compatibility with old versions and other vendors.
Fixes: https://gitlab.gnome.org/GNOME/gvfs/-/issues/584
|
| |
|
|
|
|
|
|
| |
The files generated on configure time have been improved by the
stacking multiple configuration processes, use of generator tags and
the use of dictionaries.
|
|
|
|
|
|
| |
To be consistent with the whole set of build files, the
`include_directories` have been replaced by string based
alternative.
|
|
|
|
|
|
|
|
|
| |
Dictionaries can be used to ease `foreach` statements due to their
natural unpacking system[0].
This system has been used to ease some loops.
[0] https://mesonbuild.com/Syntax.html#foreach-with-a-dictionary
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since meson 0.51 dependencies have a new generic `get_variable`
method[0], and in meson 0.56 the older `get_pkgconfig_variable` has
been deprecated[1].
All the calls to deprecated `get_pkgconfig_variable` have been
replaced by `get_variable`.
Required meson version has also been bumped to 0.56.
[0] https://mesonbuild.com/Release-notes-for-0-51-0.html#dependency-objects-now-have-a-get_variable-method
[1] https://mesonbuild.com/Release-notes-for-0-56-0.html#deprecate-dependencyget_pkgconfig_variable-and-dependencyget_configtool_variable
|
|
|
|
|
|
|
|
|
|
|
|
| |
The external program object returned by `find_program()` has been
fixed and its `path` method has been deprecated and `full_path` is
the method to be called[0].
The deprecated `path` method has been updated in meson build files.
Required meson version has also been bumped to 0.55.
[0] https://mesonbuild.com/Release-notes-for-0-55-0.html#find_program-fixes-when-the-program-has-been-overridden-by-executable
|
|
|
|
|
| |
The DAVS test cases currently fail among others because of too old
glib-networking. Let's include also glib-networking to Dockerfile.
|
|
|
|
|
| |
Currently, each dependency is listed explicitely in Dockerfile. Let's simplify
it using the dnf-builddep plugin.
|
|
|
|
|
|
| |
The `g_spawn_check_exit_status` function is deprecated now and
`g_spawn_check_wait_status` should be used instead. Let's make that
change and bump the glib dependency accordingly.
|
|
|
|
|
|
| |
There are various problems with the rawhide image currently and I don't
know how to workaround them. Let's use fedora:latest (temporarily) to fix
our pipeline.
|
|
|
|
|
| |
This is needed for testing the libsoup3 port:
https://gitlab.gnome.org/GNOME/gvfs/-/merge_requests/115
|
|
|
|
| |
This reverts commit 0114b4ebb0e00390a788338fa3fe6b8b8c1036b5.
|
|
|
|
|
| |
For some reason, "buildah login" is not enough with fedora:latest
and "buildah push --creds" needs to be used to make it work again.
|