| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
GAsyncReadyCallback is never called from g_drive_stop, because
source_tag is not set, but checked. This obviously causes issues
for client applications. Add missing source_tag.
Closes: https://gitlab.gnome.org/GNOME/gvfs/issues/1
|
|
|
|
|
|
| |
udisks2 volume monitor contains some variables, or debug prints which
contains gdu prefixes, or functionality. Let's rename, or remove
that stuff.
|
|
|
|
|
|
| |
GSimpleAsyncResult is deprecated in favour of GTask and should be replaced.
https://bugzilla.gnome.org/show_bug.cgi?id=747412
|
|
|
|
|
|
|
|
|
| |
The generic_text variable is used currently to determine which strings
should be used for notifications. It is TRUE if unmounting (i.e. mount
is set) and FALSE otherwise (i.e. drive is set). Remove this variable
and make it more obvious...
https://bugzilla.gnome.org/show_bug.cgi?id=775891
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Nautilus wants to show entries in the sidebar only for removable devices.
It uses currently sort of conditions to determine which devices should be
shown. Those condition fails in some cases unfortunatelly. Lets provide
g_drive_is_removable() which uses udisks Removable property to determine
which devices should be shown. It should return true for all drives with
removable media, or flash media, or drives on usb and firewire buses.
Add support for this property also in gvfs-mount tool.
Bump GLib version accordingly.
https://bugzilla.gnome.org/show_bug.cgi?id=765457
|
|
|
|
|
|
|
| |
Commit beea21e introduced incompatible-pointer-types warnings, because
incompatible types was used. Fix the wrong types to avoid such warnings.
https://bugzilla.gnome.org/show_bug.cgi?id=763890
|
|
|
|
|
|
|
|
|
|
| |
The eject/stop operation fails currently with "Cannot eject drive in
use: Encrypted device /dev/sdb1 is unlocked" if any volume is unlocked
and isn't mounted. The volume monitor is able to mount already unlocked
volumes, so it should be able to eject unlocked volumes also. Lock the
unlocked volumes if there are any before eject/stop operation.
https://bugzilla.gnome.org/show_bug.cgi?id=763890
|
|
|
|
|
|
|
|
|
| |
"You can now unplug..." notification is shown regardless of errors
currently. Error dialog is shown together with this notification.
Device might be still mounted and it might not be safe to unmount it.
Therefore show this notification only if there are no errors.
https://bugzilla.gnome.org/show_bug.cgi?id=746769
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=712382
|
|
|
|
|
|
|
| |
If the drive is using removable media, we want the shell and file
manager to eject the media, not turn the drive off.
Signed-off-by: David Zeuthen <zeuthen@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this change, USB-connected drives that appear *during* the user
session will now be powered off when the user clicks the "Eject" icon
in the GUI. This involves powering off the USB port typically
resulting in LEDs and other user-visible features turning off. In
particular, bus-powered HDDs will completely turn off by virtue of
being, well, bus-powered.
This is generally what users expect and should make them feel all
cozy, warm inside and, most importantly, more confident removing the
device now that the LED is off. Or something.
Since we only do this for devices detected *during* the user session,
we should not run into problems with internal USB devices such as
laptop SD card readers or the various 4-in-1 flash card readers in
many workstations. This is actually important because removing the
power to the USB port of an "internal" device is generally a bad idea
as it requires a system restart to make the laptop BIOS power the port
up again (or the user to crack open the chassis).
(No, unfortunately there is no *reliable* way to determine if a USB
device is "internal" (e.g. reachable and/or servicable by the user) or
not. There are a couple of mechanisms - one is to look at various USB
device descriptors - but none of them seem very reliable. So instead
we simply look at whether the device is hotplugged.)
See also this udisks commit
http://cgit.freedesktop.org/udisks/commit/?id=81dcb6eeaeceb6c6faae1a40a5b34a65cd5af653
introducing the Drive:CanPowerOff property and the Drive.PowerOff()
method.
Signed-off-by: David Zeuthen <zeuthen@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Without this fix volumes would fall back to folder-remote-symbolic
which is obviosly wrong. With this fix, it looks correct, see
http://people.freedesktop.org/~david/gvfs-udisks2-symbolic-icons.png
Right now we only use the API if it's available - things still work
with udisks >= 1.97.
Signed-off-by: David Zeuthen <zeuthen@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Updating the address of the FSF.
This has been done by:
while read file; do
sed -i 's:59 Temple Place:51 Franklin Street:' $file
sed -i 's:Suite 330:Fifth Floor:' $file
sed -i 's:02111-1307:02110-1301:' $file
done
https://bugzilla.gnome.org/show_bug.cgi?id=656598
Signed-off-by: Tomas Bzatek <tbzatek@redhat.com>
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=676111
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=676111
|
|
|
|
|
|
|
|
| |
We were not free-ing the UnmountMountsOp structure when there was an
error in one mount. Fix that and use g_list_free_full to make code more
concise.
https://bugzilla.gnome.org/show_bug.cgi?id=676111
|
|
|
|
|
|
| |
... instead of unmounting.
Signed-off-by: David Zeuthen <davidz@redhat.com>
|
|
|
|
|
| |
Yes, can_eject can be TRUE even if the media is not removable.
Signed-off-by: David Zeuthen <davidz@redhat.com>
|
|
|
|
| |
Signed-off-by: David Zeuthen <davidz@redhat.com>
|
|
|
|
| |
Signed-off-by: David Zeuthen <davidz@redhat.com>
|
|
|
|
|
|
| |
This ensures the drive sorting order defined by udisks is used.
Signed-off-by: David Zeuthen <davidz@redhat.com>
|
|
|
|
| |
Signed-off-by: David Zeuthen <davidz@redhat.com>
|
|
|
|
|
|
| |
This depends on the GIO patch in https://bugzilla.gnome.org/show_bug.cgi?id=661711
Signed-off-by: David Zeuthen <davidz@redhat.com>
|
|
|
|
| |
Signed-off-by: David Zeuthen <davidz@redhat.com>
|
|
|
|
| |
Signed-off-by: David Zeuthen <davidz@redhat.com>
|
|
|
|
| |
Signed-off-by: David Zeuthen <davidz@redhat.com>
|
|
|
|
| |
Signed-off-by: David Zeuthen <davidz@redhat.com>
|
|
|
|
| |
Signed-off-by: David Zeuthen <davidz@redhat.com>
|
|
|
|
| |
Signed-off-by: David Zeuthen <davidz@redhat.com>
|
|
Still a lot of stuff missing.
Signed-off-by: David Zeuthen <davidz@redhat.com>
|