| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
See https://developer.gnome.org/hig/stable/typography.html
https://bugzilla.gnome.org/show_bug.cgi?id=772219
|
|
|
|
|
|
| |
GSimpleAsyncResult is deprecated in favour of GTask and should be replaced.
https://bugzilla.gnome.org/show_bug.cgi?id=747412
|
|
|
|
|
|
| |
GSimpleAsyncResult is deprecated in favour of GTask and should be replaced.
https://bugzilla.gnome.org/show_bug.cgi?id=747412
|
|
|
|
|
|
| |
GSimpleAsyncResult is deprecated in favour of GTask and should be replaced.
https://bugzilla.gnome.org/show_bug.cgi?id=747412
|
|
|
|
|
|
| |
GSimpleAsyncResult is deprecated in favour of GTask and should be replaced.
https://bugzilla.gnome.org/show_bug.cgi?id=747412
|
|
|
|
|
|
| |
GSimpleAsyncResult is deprecated in favour of GTask and should be replaced.
https://bugzilla.gnome.org/show_bug.cgi?id=747412
|
|
|
|
|
|
| |
GSimpleAsyncResult is deprecated in favour of GTask and should be replaced.
https://bugzilla.gnome.org/show_bug.cgi?id=747412
|
|
|
|
|
|
| |
GSimpleAsyncResult is deprecated in favour of GTask and should be replaced.
https://bugzilla.gnome.org/show_bug.cgi?id=747412
|
|
|
|
|
|
|
|
|
|
|
|
| |
When systemd user units installation is disabled, SystemdService
entry should also not be present on D-Bus service files.
This patch adds a common D-Bus service file template allowing,
an homogeneus D-Bus service file generation and also a
SystemService entry conditioned to the systemd user units
installation option.
https://bugzilla.gnome.org/show_bug.cgi?id=786149
|
|
|
|
|
|
|
| |
The GIO_MODULE_DIR macro is using an invalid variable for GIO module
dir. This patch fixes the variable name.
https://bugzilla.gnome.org/show_bug.cgi?id=786149
|
|
|
|
|
|
|
| |
This patch adds support for elogind in meson, which is systemd-login
extracted as a standalone package.
https://bugzilla.gnome.org/show_bug.cgi?id=788707
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of being hardcoded, D-Bus, systemd and GIO modules paths
can be checked by using the information in their correspondant
pkg-config files.
This patch uses the information on pkg-config files by default,
and also allows the user to provide this information to avoid
overwriting system files.
https://bugzilla.gnome.org/show_bug.cgi?id=786149
|
|
|
|
|
|
|
|
|
| |
The GDU monitor service file is not created properly due to missing
service name variable declaration.
This patch adds the variable declaration which fixes the problem.
https://bugzilla.gnome.org/show_bug.cgi?id=786149
|
|
|
|
|
|
|
|
| |
meson_options.txt is hard to read. Let's create sorted groups of options
and unify the description. Also change some option names to match
correspoding backend names.
https://bugzilla.gnome.org/show_bug.cgi?id=786149
|
|
|
|
|
|
|
|
| |
meson is a build system focused on speed an ease of use, which
helps speeding up the software development. This patch adds meson
support along autotools.
https://bugzilla.gnome.org/show_bug.cgi?id=786149
|
|
|
|
|
|
|
|
| |
The device file checks were added by mistake and it is not clear whether
it can't have some side-effect. Let's remove them and use g_strcmp0 for
sysfs path comparison for sure...
https://bugzilla.gnome.org/show_bug.cgi?id=789491
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=789491
|
|
|
|
|
|
|
|
| |
It doesn't make sense to have commented g_debug prints, then they are
totally unusable. Let's uncomment them, so they can be printed if
G_MESSAGES_DEBUG is specified...
https://bugzilla.gnome.org/show_bug.cgi?id=789491
|
|
|
|
|
|
|
|
| |
UDev events for devices without ID_GPHOTO2 property are ignored.
Although ID_GPHOTO2 seems don't have to be set for device when removing
and thus the volume is not removed. Let's ignore ID_GPHOTO2 when removing.
https://bugzilla.gnome.org/show_bug.cgi?id=789491
|
|
|
|
|
|
|
|
| |
UDev events for devices without ID_MTP_DEVICE property are ignored.
Although ID_MTP_DEVICE seems don't have to be set for device when removing
and thus the volume is not removed. Let's ignore ID_MTP_DEVICE when removing.
https://bugzilla.gnome.org/show_bug.cgi?id=789491
|
|
|
|
|
|
|
|
|
|
|
|
| |
Automatic shadow mount handling in some cases works currently only thanks
to the bug in g_daemon_file_prefix_matches implementation, which I am going
to fix. The problematic case is when activation_root is equal to mount_root
(e.g. Nextcloud integration). The bug in _prefix_matches causes that it
succeeds also if the paths are equal, but this is wrong as per the docs.
Let's use also g_file_equal when looking for shadow mounts in order to fix
this issue.
https://bugzilla.gnome.org/show_bug.cgi?id=786217
|
|
|
|
|
|
|
|
|
| |
Password-based authentication used for ownCloud/Nextcloud was broken
by GTask port (commit fdda284). GTask is used as user_data for async
callbacks currently, however, user_data is incorrectly cast to MountOp
in this case. Use g_task_get_task_data in order to fix this issue.
https://bugzilla.gnome.org/show_bug.cgi?id=780496
|
|
|
|
|
|
|
|
|
| |
The generic_text variable is used currently to determine which strings
should be used for notifications. It is TRUE if unmounting (i.e. mount
is set) and FALSE otherwise (i.e. drive is set). Remove this variable
and make it more obvious...
https://bugzilla.gnome.org/show_bug.cgi?id=775891
|
|
|
|
|
|
|
| |
Do not address the user directly in the strings. Add a missing
description for the notifications.
https://bugzilla.gnome.org/show_bug.cgi?id=775891
|
|
|
|
|
|
|
| |
Error strings in gvfsproxyvolumemonitordaemon.c are not marked as
translatable and thus it might be shown untranslated in UI, mark them.
https://bugzilla.gnome.org/show_bug.cgi?id=776616
|
|
|
|
|
|
|
|
|
|
|
|
| |
"You can now unplug %s\n" is used for mounts with filesystem,
"%s has been unmounted\n" is used otherwise when unmounting.
It is confusing to say "unplug" for drives with multiple mounts,
or for drives, which need to be ejected, or stopped. I think
"unplug" should be used only when ejecting, or stopping. It might
lead to data loss if user unplug the device after unmounting one
of several mounts.
https://bugzilla.gnome.org/show_bug.cgi?id=774192
|
|
|
|
|
|
|
|
| |
gvfs_udisks2_volume_get_uuid returns NULL regardless of the output
from udisks_block_get_id_uuid currently. Set volume->uuid property
and handle its changes properly.
https://bugzilla.gnome.org/show_bug.cgi?id=772894
|
|
|
|
|
|
| |
GSimpleAsyncResult is deprecated in favour of GTask and should be replaced.
https://bugzilla.gnome.org/show_bug.cgi?id=747412
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=770671
|
|
|
|
|
| |
Let's remove code for gio < 2.31.19, GVfs already requires a newer
version.
|
|
|
|
| |
This reverts commit 078588c4698742eb8c3308275f5bc457f72b2302.
|
|
|
|
| |
This reverts commit b77369832fd6fb97e1f036998663f2488ff15022.
|
|
|
|
|
|
|
|
|
| |
Volume is not included currently if it has multiple mount points
and one of them is not considered as user interesting. Change this
logic and include all volumes with at least one user interesting
mount point.
https://bugzilla.gnome.org/show_bug.cgi?id=772306
|
|
|
|
|
|
| |
See https://developer.gnome.org/hig/stable/typography.html
https://bugzilla.gnome.org/show_bug.cgi?id=772219
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
System mounts (i.e. autofs) can be considered as user interesting
currently if mount paths are user interesting. However, we should
not handle those mounts as GMounts, because consequently redundant
mounts are offered by volume monitor. It also causes automounts of
autofs filesystems.
$ mount | grep /media/test
systemd-1 on /media/test type autofs ...
localhost:/home/oholy on /media/test type nfs4 ...
https://bugzilla.gnome.org/show_bug.cgi?id=771740
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mount path is used to match mount points currently, however device
path should be used also in order to be sure it is really corresponding
mount point. Same mount path can be used for multiple mount entries
(it is also used e.g. for autofs).
$ mount | grep /media/test
systemd-1 on /media/test type autofs ...
localhost:/home/oholy on /media/test type nfs4 ...
https://bugzilla.gnome.org/show_bug.cgi?id=771740
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The first time we connect the device, we won't be able to create a
lockdown client with a handshake, so the volume won't be created at all
and will not show up in nautilus.
Furthermore, we were checking the OS version with a paired lockdown
client (which is not needed, an unpaired one will do just as well)
and checking whether HouseArrest was supported even if the service was
different.
So, we never needed to have a paired lockdown client in the first place,
and we only need to check for the OS version if HouseArrest is what was
requested.
https://bugzilla.gnome.org/show_bug.cgi?id=767399
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=767399
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=767349
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Nautilus wants to show entries in the sidebar only for removable devices.
It uses currently sort of conditions to determine which devices should be
shown. Those condition fails in some cases unfortunatelly. Lets provide
g_drive_is_removable() which uses udisks Removable property to determine
which devices should be shown. It should return true for all drives with
removable media, or flash media, or drives on usb and firewire buses.
Add support for this property also in gvfs-mount tool.
Bump GLib version accordingly.
https://bugzilla.gnome.org/show_bug.cgi?id=765457
|
|
|
|
|
|
|
| |
Commit beea21e introduced incompatible-pointer-types warnings, because
incompatible types was used. Fix the wrong types to avoid such warnings.
https://bugzilla.gnome.org/show_bug.cgi?id=763890
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Code handling external unlocks during mount operation was added by the
commit beea21e recently. Unfortunately, it may cause crashes due to
accessing already freed memory, because gvfs_udisks2_volume_monitor_update
waits for pending dbus messages using udisks_client_settle, thus another
main context iteration may happen (i.e. mount operation may finish and
mount data may be freed) before accessing mount data pointer. The mount
data pointer has to be obtained after gvfs_udisks2_volume_monitor_update
call in order to fix this crashes.
https://bugzilla.gnome.org/show_bug.cgi?id=765146
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mount operation for encrypted volumes consists from two udisks2 calls
(unlock and mount). Volume monitor is able to mount already unlocked
volumes. However password prompt doesn't disappear if the volume is
unlocked externally and any reaction causes mount operation failure.
The volume may be unlocked externally by e.g. project Tang, see
https://github.com/latchset/tang for more details. Abort mount
operation and continue with mounting in such situations.
https://bugzilla.gnome.org/show_bug.cgi?id=763890
|
|
|
|
|
|
|
|
|
|
| |
The eject/stop operation fails currently with "Cannot eject drive in
use: Encrypted device /dev/sdb1 is unlocked" if any volume is unlocked
and isn't mounted. The volume monitor is able to mount already unlocked
volumes, so it should be able to eject unlocked volumes also. Lock the
unlocked volumes if there are any before eject/stop operation.
https://bugzilla.gnome.org/show_bug.cgi?id=763890
|
|
|
|
|
|
| |
As can happen with some iOS and libplist combinations.
https://bugzilla.gnome.org/show_bug.cgi?id=749639
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There's no interesting data for users in afc:/// so it's best to show
iDevices through MTP instead. The only reason we'd want to use this
mount is if we had support for accessing the iTunes database.
Unfortunately, this database needs to be encrypted, and we don't know
how to encrypt it.
Even then, we would probably want the default AFC service to be hidden
so only applications access it, and not users.
https://bugzilla.gnome.org/show_bug.cgi?id=749639
|
|
|
|
|
|
|
| |
There's no interesting data for users in afc:/// so it's best to show
iDevices through MTP instead. Stop hiding iDevices through the MTP.
https://bugzilla.gnome.org/show_bug.cgi?id=749639
|
|
|
|
|
|
|
|
|
|
| |
Unmount notification is sent for each volume when stopping drive,
which is wrong. It may lead to data loss, because user may unplug
the device after the first notification, before the device is really
stopped. It should be handled similary as an eject operation and
send the notification only once for the drive.
https://bugzilla.gnome.org/show_bug.cgi?id=760523
|
|
|
|
|
|
|
|
|
| |
Commit c014b64 was pushed to prevent race between unmount reply and
retry timer. Result of mount operation reply should be stored if
unmount operation is in progress, however it isn't, because the
conditional statement is always true. Fix the condition accordingly.
https://bugzilla.gnome.org/show_bug.cgi?id=678555
|
|
|
|
|
|
|
|
|
|
|
| |
This option allows maintainers to specify the directory that contain
a systemd user units, or disable it. Default location for these units
is /usr/lib/systemd/user. This patch will switch from hard-coded path
to configurable one.
The patch was modified by Ondrej Holy <oholy@redhat.com>.
https://bugzilla.gnome.org/show_bug.cgi?id=760293
|