| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This merge brings in the libmtp based backend for MTP devices.
Previously, MTP devices were handled, with limited success by the
GPhoto2 backend as MTP is nominally backwards compatible with PTP.
The most serious limitation was that the GPhoto2 backend operated
in a way that doesn't work reliably with Android 4.x based devices.
This problem is rectified by the new MTP backend.
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| | |
Use a dynamically allocated buffer instead to avoid any
multi-threading dangers.
|
| | |
|
| | |
|
| |
| |
| |
| | |
We can consider the volume monitor done at this point.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
If the drive is using removable media, we want the shell and file
manager to eject the media, not turn the drive off.
Signed-off-by: David Zeuthen <zeuthen@gmail.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
With this change, USB-connected drives that appear *during* the user
session will now be powered off when the user clicks the "Eject" icon
in the GUI. This involves powering off the USB port typically
resulting in LEDs and other user-visible features turning off. In
particular, bus-powered HDDs will completely turn off by virtue of
being, well, bus-powered.
This is generally what users expect and should make them feel all
cozy, warm inside and, most importantly, more confident removing the
device now that the LED is off. Or something.
Since we only do this for devices detected *during* the user session,
we should not run into problems with internal USB devices such as
laptop SD card readers or the various 4-in-1 flash card readers in
many workstations. This is actually important because removing the
power to the USB port of an "internal" device is generally a bad idea
as it requires a system restart to make the laptop BIOS power the port
up again (or the user to crack open the chassis).
(No, unfortunately there is no *reliable* way to determine if a USB
device is "internal" (e.g. reachable and/or servicable by the user) or
not. There are a couple of mechanisms - one is to look at various USB
device descriptors - but none of them seem very reliable. So instead
we simply look at whether the device is hotplugged.)
See also this udisks commit
http://cgit.freedesktop.org/udisks/commit/?id=81dcb6eeaeceb6c6faae1a40a5b34a65cd5af653
introducing the Drive:CanPowerOff property and the Drive.PowerOff()
method.
Signed-off-by: David Zeuthen <zeuthen@gmail.com>
|
| |
| |
| |
| |
| |
| |
| | |
We need to set initial value to local variables we're about to use
later in the code.
Found the volume monitor segfaulting on stable udisks-2.0.0
|
| |
| |
| |
| |
| | |
A matter of developer's taste, but since the function has been simplified
a lot, no need to keep the goto around.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The the_volume_monitors hash table is a shared global instance, make
sure to only initialize it once.
Based on a patch by Tim Lunn <tim@feathertop.org>
https://bugzilla.gnome.org/show_bug.cgi?id=689946
|
| |
| |
| |
| |
| |
| | |
Found by reviewing usage of the global lock, this place is not obvious
whether is inside the lock or not. Let's add a simple comment to make it
clear.
|
| |
| |
| |
| |
| |
| |
| | |
... and also the new Block:HintSymbolicIcon icon just added to udisks
master.
Signed-off-by: David Zeuthen <zeuthen@gmail.com>
|
| |
| |
| |
| | |
Signed-off-by: David Zeuthen <zeuthen@gmail.com>
|
| |
| |
| | |
Signed-off-by: David Zeuthen <zeuthen@gmail.com>
|
| |
| |
| |
| |
| |
| |
| | |
We were returning folder-remote-symbolic which is incorrect since that
should only be used for network filesystems.
Signed-off-by: David Zeuthen <zeuthen@gmail.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Without this fix volumes would fall back to folder-remote-symbolic
which is obviosly wrong. With this fix, it looks correct, see
http://people.freedesktop.org/~david/gvfs-udisks2-symbolic-icons.png
Right now we only use the API if it's available - things still work
with udisks >= 1.97.
Signed-off-by: David Zeuthen <zeuthen@gmail.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Do not connect to session bus at module load, let proxies to get
a bus when needed. No need to keep it active all the time. Proxies
will return an error when a bus is unavailable.
Also don't close the shared d-bus connection on module unload, let
it be managed by proxies.
https://bugzilla.gnome.org/show_bug.cgi?id=687074
|
| |
| |
| |
| |
| |
| |
| | |
We're on shared session bus, let's exit when connection closes
(usually tied to running desktop session).
https://bugzilla.gnome.org/show_bug.cgi?id=687074
|
| |
| |
| |
| |
| |
| | |
See http://git.gnome.org/browse/glib/commit/?id=2002479c02fa6e468fc3f67ddc663657a52ebde8
https://bugzilla.gnome.org/show_bug.cgi?id=687236
|
| |
| |
| |
| | |
This will also be used for the test suite
|
| |
| |
| |
| |
| |
| |
| |
| | |
If a device has an ID_MEDIA_PLAYER udev property, add the
x-content/audio-player content type so that gvfs clients like nautilus offer
opening an audio player instead of a file browser.
https://bugzilla.gnome.org/show_bug.cgi?id=619583
|
|/
|
|
|
|
|
|
| |
It's unnecessary to emit those signals when the object is created, and
it can cause weird side-effects if applications e.g. play a sound on
signal emission.
https://bugzilla.gnome.org/show_bug.cgi?id=684677
|
| |
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=582579
|
|
|
|
|
|
|
|
|
|
| |
... in order to be able to compile.
gvfsdbusutils.c was removed by commit 288e9153f1f though hal still
needs it for compilation. Let's make it private to hal and strip
unnecessary functions.
https://bugzilla.gnome.org/show_bug.cgi?id=683367
|
|
|
|
|
|
| |
Just a little cleanup to be on a safe side.
https://bugzilla.gnome.org/show_bug.cgi?id=683191
|
| |
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=681458
|
|
|
|
|
|
|
|
| |
The gvfsmountinfo.c (and its libbluray dependency) is unused by
the client code, so we remove it from the common shared lib.
We use a non-shared lib for this, as in practice only one of the
monitors that use this code will be build/installed/used.
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=682284
|
|
|
|
|
|
| |
Based on an initial port by Stef Walter
https://bugzilla.gnome.org/show_bug.cgi?id=679854
|
| |
|
|
|
|
|
|
|
| |
Unify the spelling. For the discussion see:
https://bugzilla.gnome.org/show_bug.cgi?id=520902
Signed-off-by: Tomas Bzatek <tbzatek@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Updating the address of the FSF.
This has been done by:
while read file; do
sed -i 's:59 Temple Place:51 Franklin Street:' $file
sed -i 's:Suite 330:Fifth Floor:' $file
sed -i 's:02111-1307:02110-1301:' $file
done
https://bugzilla.gnome.org/show_bug.cgi?id=656598
Signed-off-by: Tomas Bzatek <tbzatek@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Some GVolumeMonitor users don't run mainloop thus we're not able
to do any async I/O. Using GDBusProxy name owner monitoring should
get us the same functionality as separate g_bus_watch_name() call
with the benefit of not doing any async I/O in GProxyVolumeMonitor
constructor. This way we could populate volume monitor objects
during initialization.
https://bugzilla.gnome.org/show_bug.cgi?id=679821
|
|
|
|
| |
Signed-off-by: David Zeuthen <zeuthen@gmail.com>
|
|
|
|
|
|
|
| |
Also set the Autoclear property after successfully mounting/unlocking
devices on a loop device.
Signed-off-by: David Zeuthen <zeuthen@gmail.com>
|
|
|
|
|
|
| |
We also want these checks to apply to e.g. LUKS devices.
Signed-off-by: David Zeuthen <zeuthen@gmail.com>
|
|
|
|
|
|
|
|
| |
Technically there's no problem here since UDisksClient still has a
reference but it's pretty confusing. Fix it up by using
g_clear_object().
Signed-off-by: David Zeuthen <zeuthen@gmail.com>
|
|
|
|
| |
Signed-off-by: David Zeuthen <zeuthen@gmail.com>
|
|
|
|
|
| |
Use G_DBUS_PROXY_FLAGS_DO_NOT_CONNECT_SIGNALS and G_DBUS_PROXY_FLAGS_DO_NOT_LOAD_PROPERTIES
flags where applicable.
|