diff options
| author | Thomas Miedema <thomasmiedema@gmail.com> | 2016-05-25 13:24:34 +0200 |
|---|---|---|
| committer | Thomas Miedema <thomasmiedema@gmail.com> | 2016-05-27 22:49:29 +0200 |
| commit | d40682ec74d802376d7cf50f2d3612b3292b29c5 (patch) | |
| tree | cfde4072ce14677621aa99d75a59228aea5922b1 /.arc-linters/check-cpp.py | |
| parent | d0dd572b707631a104e060711faf9bd169bdc968 (diff) | |
| download | haskell-d40682ec74d802376d7cf50f2d3612b3292b29c5.tar.gz | |
Testsuite: don't use --interactive in Makefiles
Add a linter to encourage the use of `$(TEST_HC_OPTS_INTERACTIVE)`
instead of `$(TEST_HC_OPTS) --interactive -ignore-dot-ghci -v0`. It's
too easy to forget one of those flags when adding a new test.
Update submodule hpc.
Reviewed by: austin
Differential Revision: https://phabricator.haskell.org/D2265
GHC Trac Issues: #11468
Diffstat (limited to '.arc-linters/check-cpp.py')
| -rwxr-xr-x | .arc-linters/check-cpp.py | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/.arc-linters/check-cpp.py b/.arc-linters/check-cpp.py index 1d07b4ed37..2f32f9be6a 100755 --- a/.arc-linters/check-cpp.py +++ b/.arc-linters/check-cpp.py @@ -7,7 +7,6 @@ import sys import logging import os import json -import re def setup_logging(logger): """ @@ -28,7 +27,7 @@ warnings = [] if os.path.isfile(path): with open(path) as f: for lineno, line in enumerate(f): - if re.search('ASSERT \(', line) is not None: + if 'ASSERT (' in line: warning = { 'severity': 'warning', 'message': 'CPP macros should not have a space between the macro name and their argument list', |