diff options
| author | Moritz Angermann <moritz.angermann@gmail.com> | 2021-03-02 16:35:09 +0800 |
|---|---|---|
| committer | Moritz Angermann <moritz.angermann@gmail.com> | 2021-03-07 22:19:20 +0800 |
| commit | a69e0dc72ffeb7eaf4663d7b971ec72afbf063e6 (patch) | |
| tree | 52817d463d2e27eeeb69d7be6c86363a15ee73fb /.gitlab-ci.yml | |
| parent | a85d25e492f89b7412b16fc36025b524338798ff (diff) | |
| download | haskell-a69e0dc72ffeb7eaf4663d7b971ec72afbf063e6.tar.gz | |
[aarch64/elf] fix note parsing
Notes appear to be 8byte aligned instead of 4 as on x86_64 :facepalm:
See: https://reviews.llvm.org/D70962
> The .note.gnu.property SHT_NOTE sections on AArch64 (a 64-bit target) should have alignment 8 to more closely match the binutils implementation where alignment is 4-bytes on 32-bit machines and 8-bytes on 64-bit machines.
> Previously LLD was using 4 for both 32-bit and 64-bit machines.
> There was a long discussion on the right alignment of the .note.gnu.property section on the binutils mailing list. The basic argument was that generic ELF requires 8-byte alignment for SHT_NOTES sections, however this hadn't been respected by other GNU notes sections. The implementation in GNU ld uses 8 and as there is no binary legacy of using 4 in LLD (BTI is only just being picked up and used) I'd like to keep LLD in line with GNU ld.
> Although at present LLD only does something useful with AArch64 properties, this also applies to X86.
Diffstat (limited to '.gitlab-ci.yml')
0 files changed, 0 insertions, 0 deletions