summaryrefslogtreecommitdiff
path: root/.gitlab
diff options
context:
space:
mode:
authorRichard Eisenberg <rae@richarde.dev>2020-05-14 06:38:42 -0400
committerMarge Bot <ben+marge-bot@smart-cactus.org>2020-05-21 12:18:45 -0400
commit2b363ebb988cbf8c92df24eef5366293a80ecb19 (patch)
tree62e3555127d14608b348c1ac7869eac1ac6cc25c /.gitlab
parent892b0c41816fca4eeea42ca03a43aac473311837 (diff)
downloadhaskell-2b363ebb988cbf8c92df24eef5366293a80ecb19.tar.gz
MR template should ask for key part
Diffstat (limited to '.gitlab')
-rw-r--r--.gitlab/merge_request_templates/merge-request.md7
1 files changed, 6 insertions, 1 deletions
diff --git a/.gitlab/merge_request_templates/merge-request.md b/.gitlab/merge_request_templates/merge-request.md
index 3bd30a45b0..4cecbdb3ab 100644
--- a/.gitlab/merge_request_templates/merge-request.md
+++ b/.gitlab/merge_request_templates/merge-request.md
@@ -1,5 +1,10 @@
Thank you for your contribution to GHC!
+**Please read the checklist below to make sure your contribution fulfills these
+expectations. Also please answer the following question in your MR description:**
+
+**Where is the key part of this patch? That is, what should reviewers look at first?**
+
Please take a few moments to verify that your commits fulfill the following:
* [ ] are either individually buildable or squashed
@@ -10,7 +15,7 @@ Please take a few moments to verify that your commits fulfill the following:
likely should add a [Note][notes] and cross-reference it from the relevant
places.
* [ ] add a [testcase to the testsuite](https://gitlab.haskell.org/ghc/ghc/wikis/building/running-tests/adding).
- * [ ] if your MR affects library interfaces (e.g. changes `base`) please add
+ * [ ] if your MR affects library interfaces (e.g. changes `base`) or affects whether GHC will accept user-written code, please add
the ~"user facing" label.
* [ ] updates the users guide if applicable
* [ ] mentions new features in the release notes for the next release