summaryrefslogtreecommitdiff
path: root/.gitlab
diff options
context:
space:
mode:
authorMatthew Pickering <matthewtpickering@gmail.com>2021-11-29 16:15:36 +0000
committerMarge Bot <ben+marge-bot@smart-cactus.org>2021-12-01 03:11:45 -0500
commitc2f6cbef77203b7698f6484719ed9902f905496c (patch)
tree57f03a6d665b07927173913293d7f38b9cb2d4bf /.gitlab
parent59b2794550611879362c7170d6005c6b4f08e3c5 (diff)
downloadhaskell-c2f6cbef77203b7698f6484719ed9902f905496c.tar.gz
Fix several quoting issues in testsuite
This fixes the ./validate script on my machine. I also took the step to add some linters which would catch problems like these in future. Fixes #20506
Diffstat (limited to '.gitlab')
-rwxr-xr-x.gitlab/linters/check-makefiles.py12
1 files changed, 12 insertions, 0 deletions
diff --git a/.gitlab/linters/check-makefiles.py b/.gitlab/linters/check-makefiles.py
index b36b073cba..5a8286c6a7 100755
--- a/.gitlab/linters/check-makefiles.py
+++ b/.gitlab/linters/check-makefiles.py
@@ -23,9 +23,21 @@ test_hc_quotes_linter = \
message = "Warning: $(TEST_HC) should be quoted in Makefiles.",
).add_path_filter(lambda path: path.name == 'Makefile')
+ghc_pkg_quotes_linter = \
+ RegexpLinter('\t\\$\\(GHC_PKG\\)',
+ message = "Warning: $(GHC_PKG) should be quoted in Makefiles.",
+ ).add_path_filter(lambda path: path.name == 'Makefile')
+
+haddock_quotes_linter = \
+ RegexpLinter('\t\\$\\(HADDOCK\\)',
+ message = "Warning: $(HADDOCK) should be quoted in Makefiles.",
+ ).add_path_filter(lambda path: path.name == 'Makefile')
+
linters = [
interactive_linter,
test_hc_quotes_linter,
+ ghc_pkg_quotes_linter,
+ haddock_quotes_linter
]
if __name__ == '__main__':