summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBen Gamari <ben@smart-cactus.org>2018-12-10 21:48:51 -0500
committerBen Gamari <ben@smart-cactus.org>2018-12-11 00:28:15 -0500
commitdc346674c4b5609e15560820b33e533e73213b32 (patch)
tree83667f9a8becb00b7b47169fac0c82383f2f0983
parente6900f081a7bce47b7c6660a6510aeb021751fb1 (diff)
downloadhaskell-dc346674c4b5609e15560820b33e533e73213b32.tar.gz
rts: Disable fallthrough attribute when compiling with Clang
Apparently clang doesn't enable implicitly fallthrough warnings by default http://llvm.org/viewvc/llvm-project?revision=167655&view=revision when compiling C and the attribute cause warnings of their own (#16019).
-rw-r--r--includes/Stg.h6
1 files changed, 5 insertions, 1 deletions
diff --git a/includes/Stg.h b/includes/Stg.h
index 9b54526342..57cb00d0a4 100644
--- a/includes/Stg.h
+++ b/includes/Stg.h
@@ -197,7 +197,11 @@
#endif
/* Used to mark a switch case that falls-through */
-#if (defined(__GNUC__) && __GNUC__ >= 7) || defined(__clang__)
+#if (defined(__GNUC__) && __GNUC__ >= 7)
+// N.B. Don't enable fallthrough annotations when compiling with Clang.
+// Apparently clang doesn't enable implicitly fallthrough warnings by default
+// http://llvm.org/viewvc/llvm-project?revision=167655&view=revision
+// when compiling C and the attribute cause warnings of their own (#16019).
#define FALLTHROUGH GNU_ATTRIBUTE(fallthrough)
#else
#define FALLTHROUGH ((void)0)