diff options
| author | Reid Barton <rwbarton@gmail.com> | 2017-01-10 14:29:11 -0500 |
|---|---|---|
| committer | Ben Gamari <ben@smart-cactus.org> | 2017-01-10 14:29:18 -0500 |
| commit | 35a5b60390f2a400d06a2209eb03b7fd6ccffdab (patch) | |
| tree | 7a0fd40f53654a8755dae8ae560e05f6245e1055 | |
| parent | c2bd62ed62d2fae126819136d428989a7b4ddc79 (diff) | |
| download | haskell-35a5b60390f2a400d06a2209eb03b7fd6ccffdab.tar.gz | |
testsuite driver: don't append to existing output files
If you happen to have a T1234.run.stdout file lying aroud (probably
from before the move to running tests in temporary subdirectories)
it gets symlinked into the T1234.run directory since its name starts
with T1234; and then program output gets appended to the existing
file (through the symlink). We should open the file for writing
instead, to replace the symlink with a new file.
Test Plan: tested locally, + harbormaster
Reviewers: austin, Phyx, bgamari
Reviewed By: Phyx, bgamari
Subscribers: thomie
Differential Revision: https://phabricator.haskell.org/D2946
| -rw-r--r-- | testsuite/driver/testlib.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/testsuite/driver/testlib.py b/testsuite/driver/testlib.py index f6729acaa8..c0135f0864 100644 --- a/testsuite/driver/testlib.py +++ b/testsuite/driver/testlib.py @@ -1801,11 +1801,11 @@ def runCmd(cmd, stdin=None, stdout=None, stderr=None, timeout_multiplier=1.0, pr sys.stderr.buffer.write(stderr_buffer) if stdout: - with io.open(stdout, 'ab') as f: + with io.open(stdout, 'wb') as f: f.write(stdout_buffer) if stderr: if stderr is not subprocess.STDOUT: - with io.open(stderr, 'ab') as f: + with io.open(stderr, 'wb') as f: f.write(stderr_buffer) if r.returncode == 98: |