diff options
| author | Niklas Hambüchen <mail@nh2.me> | 2017-09-27 15:29:06 -0400 |
|---|---|---|
| committer | Ben Gamari <ben@smart-cactus.org> | 2017-09-27 17:37:29 -0400 |
| commit | 03009aa70a099867331afb9876333c687454c5d5 (patch) | |
| tree | fd181c2e66000da96e89c3f822387c15556ec2f5 | |
| parent | dddef3114246fcd79bf0993d685454802983111b (diff) | |
| download | haskell-03009aa70a099867331afb9876333c687454c5d5.tar.gz | |
base: fdReady(): Ensure and doc that return values are always -1/0/1
Reviewers: bgamari, austin, hvr, Phyx
Reviewed By: Phyx
Subscribers: Phyx, rwbarton, thomie
Differential Revision: https://phabricator.haskell.org/D4010
| -rw-r--r-- | libraries/base/cbits/inputReady.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/libraries/base/cbits/inputReady.c b/libraries/base/cbits/inputReady.c index 21ad36db3a..30327ba811 100644 --- a/libraries/base/cbits/inputReady.c +++ b/libraries/base/cbits/inputReady.c @@ -40,6 +40,10 @@ * * This function blocks until either `msecs` have passed, or input is * available. + * + * Returns: + * 1 => Input ready, 0 => not ready, -1 => error + * On error, sets `errno`. */ int fdReady(int fd, int write, int msecs, int isSock) @@ -117,8 +121,7 @@ fdReady(int fd, int write, int msecs, int isSock) } } - /* 1 => Input ready, 0 => not ready, -1 => error */ - return (ready); + return (ready > 0); } else { DWORD rc; HANDLE hFile = (HANDLE)_get_osfhandle(fd); |