diff options
| author | AndreasPK <klebinger.andreas@gmx.at> | 2017-10-20 23:53:54 +0200 |
|---|---|---|
| committer | Ben Gamari <ben@smart-cactus.org> | 2017-10-25 15:45:35 -0400 |
| commit | bd53b488d6bf59329f33a5fb6ba2ef0170285298 (patch) | |
| tree | 88e1dd1dc3052957fe4c27b1263779669e72f5a4 | |
| parent | bf83435b5c62776072977b9b1fc5aba2bffa97b4 (diff) | |
| download | haskell-bd53b488d6bf59329f33a5fb6ba2ef0170285298.tar.gz | |
Add info about Github pull requests.
| -rw-r--r-- | HACKING.md | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/HACKING.md b/HACKING.md index ecfd35b50e..cb68889904 100644 --- a/HACKING.md +++ b/HACKING.md @@ -61,12 +61,12 @@ newly built compiler. Now, hack on your copy and rebuild (with `make`) as necessary. -Then start by making your commits however you want. When you're done, you'll -need to submit your patch to [Phabricator](https://phabricator.haskell.org/) for -code review. To do so you will need to -[install Arcanist](https://secure.phabricator.com/book/phabricator/article/arcanist/#installing-arcanist), -Phabricator's CLI tool. Once installed, you can submit your work for code review -using `arc diff`. +Then start by making your commits however you want. When you're done, you can submit + a pull request on Github for small changes. For larger changes the patch needs to be + submitted to [Phabricator](https://phabricator.haskell.org/) for code review. + The GHC Trac Wiki has a good summary for the [overall process](https://ghc.haskell.org/trac/ghc/wiki/WorkingConventions/FixingBugs) + as well as a guide on + [how to use Phabricator/arcanist](https://ghc.haskell.org/trac/ghc/wiki/Phabricator). Useful links: |