summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatthew Pickering <matthewtpickering@gmail.com>2022-03-03 09:43:27 +0000
committerMatthew Pickering <matthewtpickering@gmail.com>2022-03-04 10:12:35 +0000
commit0438cc2e62ac112bc0617b7b92a7accd71a33411 (patch)
tree81a733c72d440ba6d274eb65f2e732a68eb15fc0
parentfbab2328761e24baf4cd53c8da443355897bdba4 (diff)
downloadhaskell-0438cc2e62ac112bc0617b7b92a7accd71a33411.tar.gz
Change lookupIdSubst panic back to a warning
We don't want to backport the number of commits which were necessary to fix this issue for the 9.2.2 release so for now just turn it back into a warning. Partially reverts 0e5236add8dc83ec5f66a5e7bcb7f31d6636fcf0
-rw-r--r--compiler/GHC/Core/Subst.hs9
1 files changed, 5 insertions, 4 deletions
diff --git a/compiler/GHC/Core/Subst.hs b/compiler/GHC/Core/Subst.hs
index d062227a9b..1c7d138574 100644
--- a/compiler/GHC/Core/Subst.hs
+++ b/compiler/GHC/Core/Subst.hs
@@ -66,6 +66,7 @@ import GHC.Utils.Misc
import GHC.Utils.Outputable
import GHC.Utils.Panic
import Data.List (mapAccumL)
+import GHC.Driver.Ppr
@@ -253,10 +254,10 @@ lookupIdSubst (Subst in_scope ids _ _) v
| not (isLocalId v) = Var v
| Just e <- lookupVarEnv ids v = e
| Just v' <- lookupInScope in_scope v = Var v'
- -- Vital! See Note [Extending the Subst]
- -- If v isn't in the InScopeSet, we panic, because
- -- it's a bad bug and we reallly want to know
- | otherwise = pprPanic "lookupIdSubst" (ppr v $$ ppr in_scope)
+
+ | otherwise = WARN( True, text "GHC.Core.Subst.lookupIdSubst" <+> ppr v
+ $$ ppr in_scope)
+ Var v
-- | Find the substitution for a 'TyVar' in the 'Subst'
lookupTCvSubst :: Subst -> TyVar -> Type