diff options
| author | Ben Gamari <ben@smart-cactus.org> | 2020-10-31 12:29:28 -0400 |
|---|---|---|
| committer | Marge Bot <ben+marge-bot@smart-cactus.org> | 2020-11-02 23:48:06 -0500 |
| commit | 1370eda7a53f5dfc88afe705b2ffecb1d5544ec7 (patch) | |
| tree | 6f5321d81af176300b6d4b0c9409acf027e732b1 | |
| parent | a9e5f52c571ae3dfd4826e10a256d1a265f7e058 (diff) | |
| download | haskell-1370eda7a53f5dfc88afe705b2ffecb1d5544ec7.tar.gz | |
hadrian: Don't capture RunTest output
There are a few reasons why capturing the output of the RunTest builder
is undesirable:
* there is a large amount of output which then gets unnecessarily
duplicated by Hadrian if the builder fails
* the output may contain codepoints which are unrepresentable in the
current codepage on Windows, causing Hadrian to crash
* capturing the output causes the testsuite driver to disable
its colorisation logic, making the output less legible.
| -rw-r--r-- | hadrian/src/Builder.hs | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/hadrian/src/Builder.hs b/hadrian/src/Builder.hs index 18a64b372b..3419dee422 100644 --- a/hadrian/src/Builder.hs +++ b/hadrian/src/Builder.hs @@ -304,6 +304,11 @@ instance H.Builder Builder where Makeindex -> unit $ cmd' [Cwd output] [path] (buildArgs ++ [input]) Tar _ -> cmd' buildOptions echo [path] buildArgs + + -- RunTest produces a very large amount of (colorised) output; + -- Don't attempt to capture it. + RunTest -> cmd echo [path] buildArgs + _ -> cmd' echo [path] buildArgs -- TODO: Some builders are required only on certain platforms. For example, |