diff options
author | Krzysztof Gogolewski <krzysztof.gogolewski@tweag.io> | 2021-08-19 16:48:49 +0200 |
---|---|---|
committer | Marge Bot <ben+marge-bot@smart-cactus.org> | 2021-08-23 13:36:00 -0400 |
commit | f3892b5f57b5a75c20eb12a45575a15b2a3dfd3f (patch) | |
tree | f917c6e2dafd3c5302e8d8f71671e2e0cf3a68ca | |
parent | c1acfd210153dc78748904467c6be023c702467a (diff) | |
download | haskell-f3892b5f57b5a75c20eb12a45575a15b2a3dfd3f.tar.gz |
Convert lookupIdSubst panic back to a warning (#20200)
-rw-r--r-- | compiler/GHC/Core/Subst.hs | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/compiler/GHC/Core/Subst.hs b/compiler/GHC/Core/Subst.hs index ddb8e71f1f..1544e5b192 100644 --- a/compiler/GHC/Core/Subst.hs +++ b/compiler/GHC/Core/Subst.hs @@ -61,6 +61,7 @@ import GHC.Types.Unique.Supply import GHC.Builtin.Names import GHC.Data.Maybe +import GHC.Utils.Trace import GHC.Utils.Misc import GHC.Utils.Outputable import GHC.Utils.Panic @@ -255,9 +256,10 @@ lookupIdSubst (Subst in_scope ids _ _) v | Just e <- lookupVarEnv ids v = e | Just v' <- lookupInScope in_scope v = Var v' -- Vital! See Note [Extending the Subst] - -- If v isn't in the InScopeSet, we panic, because - -- it's a bad bug and we reallly want to know - | otherwise = pprPanic "lookupIdSubst" (ppr v $$ ppr in_scope) + -- See #20200 + | otherwise = warnPprTrace True (text "GHC.Core.Subst.lookupIdSubst" <+> ppr v + $$ ppr in_scope) $ + Var v -- | Find the substitution for a 'TyVar' in the 'Subst' lookupTCvSubst :: Subst -> TyVar -> Type |