diff options
| author | Richard Eisenberg <rae@richarde.dev> | 2020-05-14 06:38:42 -0400 |
|---|---|---|
| committer | Richard Eisenberg <rae@richarde.dev> | 2020-05-14 06:38:42 -0400 |
| commit | 5d1b5e5c75524a17b990056ff8e24a581defbe89 (patch) | |
| tree | d814762ac0b34c6896f62c1d35ffbed9ed4b9737 | |
| parent | 477f13bb4c5c2ba969d2c90890c51d7de01c5312 (diff) | |
| download | haskell-5d1b5e5c75524a17b990056ff8e24a581defbe89.tar.gz | |
MR template should ask for key partwip/mr-template-key-part
| -rw-r--r-- | .gitlab/merge_request_templates/merge-request.md | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/.gitlab/merge_request_templates/merge-request.md b/.gitlab/merge_request_templates/merge-request.md index 3bd30a45b0..4cecbdb3ab 100644 --- a/.gitlab/merge_request_templates/merge-request.md +++ b/.gitlab/merge_request_templates/merge-request.md @@ -1,5 +1,10 @@ Thank you for your contribution to GHC! +**Please read the checklist below to make sure your contribution fulfills these +expectations. Also please answer the following question in your MR description:** + +**Where is the key part of this patch? That is, what should reviewers look at first?** + Please take a few moments to verify that your commits fulfill the following: * [ ] are either individually buildable or squashed @@ -10,7 +15,7 @@ Please take a few moments to verify that your commits fulfill the following: likely should add a [Note][notes] and cross-reference it from the relevant places. * [ ] add a [testcase to the testsuite](https://gitlab.haskell.org/ghc/ghc/wikis/building/running-tests/adding). - * [ ] if your MR affects library interfaces (e.g. changes `base`) please add + * [ ] if your MR affects library interfaces (e.g. changes `base`) or affects whether GHC will accept user-written code, please add the ~"user facing" label. * [ ] updates the users guide if applicable * [ ] mentions new features in the release notes for the next release |