diff options
| author | Niklas Hambüchen <mail@nh2.me> | 2019-02-17 20:48:45 +0100 |
|---|---|---|
| committer | Marge Bot <ben+marge-bot@smart-cactus.org> | 2019-03-09 02:14:13 -0500 |
| commit | cfbedf1780002f4f76aa9c6c754818a436888e9f (patch) | |
| tree | f8497e0b7c55ee70a6e5d0ba820d802a1956e6a0 | |
| parent | 1f5cc9dc8aeeafa439d6d12c3c4565ada524b926 (diff) | |
| download | haskell-cfbedf1780002f4f76aa9c6c754818a436888e9f.tar.gz | |
compiler: Write .o files atomically. See #14533
This issue was reproduced with, and the fix confirmed with,
the `hatrace` tool for syscall-based fault injection:
https://github.com/nh2/hatrace
The concrete test case for GHC is at
https://github.com/nh2/hatrace/blob/e23d35a2d2c79e8bf49e9e2266b3ff7094267f29/test/HatraceSpec.hs#L185
A previous, nondeterministic reproducer for the issue was provided by
Alexey Kuleshevich in
https://github.com/lehins/exec-kill-loop
Signed-off-by: Niklas Hambüchen <niklas@fpcomplete.com>
Reviewed-by: Alexey Kuleshevich <alexey@fpcomplete.com>
| -rw-r--r-- | compiler/main/DriverPipeline.hs | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/compiler/main/DriverPipeline.hs b/compiler/main/DriverPipeline.hs index 04576e715c..70c2d7ae1f 100644 --- a/compiler/main/DriverPipeline.hs +++ b/compiler/main/DriverPipeline.hs @@ -1339,7 +1339,12 @@ runPhase (RealPhase (As with_cpp)) input_fn dflags ]) liftIO $ debugTraceMsg dflags 4 (text "Running the assembler") - runAssembler input_fn output_fn + + -- Atomic write by writing to temp file and then renaming + let temp_output_fn = output_fn <.> "tmp" + runAssembler input_fn temp_output_fn + liftIO $ renameFile temp_output_fn output_fn + return (RealPhase next_phase, output_fn) |