summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaroc Alden <setupminimal@gmail.com>2019-06-23 17:35:52 -0400
committerMarge Bot <ben+marge-bot@smart-cactus.org>2019-10-04 21:45:09 -0400
commitb538476be3706264620c072e6e436debf9e0d3e4 (patch)
treef495ee4611859a0e9abe9e09c93e94bfc49509a6
parent75a5dd8e614e6056edf846218c08ddfff9384e04 (diff)
downloadhaskell-b538476be3706264620c072e6e436debf9e0d3e4.tar.gz
Deprecate -fwarn-hi-shadowing, because it was never implemented and is
not used. This fixes #10913.
-rw-r--r--compiler/main/DynFlags.hs3
-rw-r--r--docs/users_guide/8.10.1-notes.rst4
-rw-r--r--docs/users_guide/using-warnings.rst13
3 files changed, 6 insertions, 14 deletions
diff --git a/compiler/main/DynFlags.hs b/compiler/main/DynFlags.hs
index d873df6333..18eb1a93b9 100644
--- a/compiler/main/DynFlags.hs
+++ b/compiler/main/DynFlags.hs
@@ -4052,7 +4052,8 @@ wWarningFlagsDeps = [
"it is subsumed by -Wredundant-constraints",
flagSpec "redundant-constraints" Opt_WarnRedundantConstraints,
flagSpec "duplicate-exports" Opt_WarnDuplicateExports,
- flagSpec "hi-shadowing" Opt_WarnHiShadows,
+ depFlagSpec "hi-shadowing" Opt_WarnHiShadows
+ "it is not used, and was never implemented",
flagSpec "inaccessible-code" Opt_WarnInaccessibleCode,
flagSpec "implicit-prelude" Opt_WarnImplicitPrelude,
depFlagSpec "implicit-kind-vars" Opt_WarnImplicitKindVars
diff --git a/docs/users_guide/8.10.1-notes.rst b/docs/users_guide/8.10.1-notes.rst
index 7566f3f019..374cf03b09 100644
--- a/docs/users_guide/8.10.1-notes.rst
+++ b/docs/users_guide/8.10.1-notes.rst
@@ -147,6 +147,10 @@ Compiler
- Add new flag :ghc-flag:`-fkeep-going` which makes the compiler
continue as far as it can despite errors.
+- Deprecated flag :ghc-flag:`-fwarn-hi-shadowing` because it was not
+ implemented correctly, and appears to be largely unused. This flag
+ will be removed in a later version of GHC.
+
GHCi
~~~~
diff --git a/docs/users_guide/using-warnings.rst b/docs/users_guide/using-warnings.rst
index 0bc7d0a946..335cdcad80 100644
--- a/docs/users_guide/using-warnings.rst
+++ b/docs/users_guide/using-warnings.rst
@@ -744,19 +744,6 @@ of ``-W(no-)*``.
This option is on by default.
-.. ghc-flag:: -Whi-shadowing
- :shortdesc: warn when a ``.hi`` file in the current directory shadows a library
- :type: dynamic
- :reverse: -Wno-hi-shadowing
- :category:
-
- .. index::
- single: shadowing; interface files
-
- Causes the compiler to emit a warning when a module or interface
- file in the current directory is shadowing one with the same module
- name in a library or other directory.
-
.. ghc-flag:: -Widentities
:shortdesc: warn about uses of Prelude numeric conversions that are probably
the identity (and hence could be omitted)