diff options
| author | Sebastian Graf <sebastian.graf@kit.edu> | 2021-06-22 14:02:49 +0200 |
|---|---|---|
| committer | Marge Bot <ben+marge-bot@smart-cactus.org> | 2021-06-27 14:57:39 -0400 |
| commit | d7758da490db3cc662dbebdac4397b4b2c38d0f0 (patch) | |
| tree | ee8da5279b12a0ca2999789e92dea81b1552df67 /compiler/GHC/Core/Ppr.hs | |
| parent | 3e71874b32725cb0bd95f6a7effc77190a860b3e (diff) | |
| download | haskell-d7758da490db3cc662dbebdac4397b4b2c38d0f0.tar.gz | |
Simplifier: Do Cast W/W for INLINE strong loop-breakers
Strong loop-breakers never inline, INLINE pragma or not.
Hence they should be treated as if there was no INLINE pragma on them.
Also not doing Cast W/W for INLINE strong loop-breakers will trip up Strictness
W/W, because it treats them as if there was no INLINE pragma. Subsequently,
that will lead to a panic once Strictness W/W will no longer do eta-expansion,
as we discovered while implementing !5814.
I also renamed to `unfoldingInfo` to `realUnfoldingInfo` and redefined
`unfoldingInfo` to zap the unfolding it returns in case of a strong loop-breaker.
Now the naming and semantics is symmetrical to `idUnfolding`/`realIdUnfolding`.
Now there was no more reason for `hasInlineUnfolding` to operate on `Id`,
because the zapping of strong loop-breaker unfoldings moved from `idUnfolding`
to `unfoldingInfo`, so I refactored it to take `IdInfo` and call it both from
the Simplifier and WorkWrap, making it utterly clear that both checks are
equivalent.
Diffstat (limited to 'compiler/GHC/Core/Ppr.hs')
| -rw-r--r-- | compiler/GHC/Core/Ppr.hs | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/compiler/GHC/Core/Ppr.hs b/compiler/GHC/Core/Ppr.hs index cc3159d646..f1791dfebf 100644 --- a/compiler/GHC/Core/Ppr.hs +++ b/compiler/GHC/Core/Ppr.hs @@ -426,7 +426,7 @@ pprTypedLamBinder bind_site debug_on var 2 (vcat [ dcolon <+> pprType (idType var) , pp_unf])) where - unf_info = unfoldingInfo (idInfo var) + unf_info = realUnfoldingInfo (idInfo var) pp_unf | hasSomeUnfolding unf_info = text "Unf=" <> ppr unf_info | otherwise = empty @@ -510,7 +510,7 @@ instance Outputable IdInfo where str_info = dmdSigInfo info has_str_info = not (isTopSig str_info) - unf_info = unfoldingInfo info + unf_info = realUnfoldingInfo info has_unf = hasSomeUnfolding unf_info rules = ruleInfoRules (ruleInfo info) @@ -557,7 +557,7 @@ ppIdInfo id info cpr_info = cprSigInfo info has_cpr_info = cpr_info /= topCprSig - unf_info = unfoldingInfo info + unf_info = realUnfoldingInfo info has_unf = hasSomeUnfolding unf_info rules = ruleInfoRules (ruleInfo info) |