diff options
author | Ryan Scott <ryan.gl.scott@gmail.com> | 2023-02-11 18:31:07 -0500 |
---|---|---|
committer | Ryan Scott <ryan.gl.scott@gmail.com> | 2023-02-20 20:44:35 -0500 |
commit | 96dc58b9225d91a7912957c6be5d9c7a95e51718 (patch) | |
tree | 6474daa75303634e8cfd6f025f795e5f4f4ea380 /compiler/GHC/Rename | |
parent | 4327d63594f73939a2b8ab015c1cb44eafd4b460 (diff) | |
download | haskell-96dc58b9225d91a7912957c6be5d9c7a95e51718.tar.gz |
Treat type data declarations as empty when checking pattern-matching coverage
The data constructors for a `type data` declaration don't exist at the value
level, so we don't want GHC to warn users to match on them.
Fixes #22964.
Diffstat (limited to 'compiler/GHC/Rename')
-rw-r--r-- | compiler/GHC/Rename/Module.hs | 22 |
1 files changed, 22 insertions, 0 deletions
diff --git a/compiler/GHC/Rename/Module.hs b/compiler/GHC/Rename/Module.hs index 8a0d6eb734..e9b8d40d83 100644 --- a/compiler/GHC/Rename/Module.hs +++ b/compiler/GHC/Rename/Module.hs @@ -2147,6 +2147,28 @@ The main parts of the implementation are: If `T` were an ordinary `data` declaration, then `A` would have a wrapper to account for the GADT-like equality in its return type. Because `T` is declared as a `type data` declaration, however, the wrapper is omitted. + +* Although `type data` data constructors do not exist at the value level, + it is still possible to match on a value whose type is headed by a `type data` + type constructor, such as this example from #22964: + + type data T a where + A :: T Int + B :: T a + + f :: T a -> () + f x = case x of {} + + This has two consequences: + + * During checking the coverage of `f`'s pattern matches, we treat `T` as if it + were an empty data type so that GHC does not warn the user to match against + `A` or `B`. (Otherwise, you end up with the bug reported in #22964.) + See GHC.HsToCore.Pmc.Solver.vanillaCompleteMatchTC. + + * In `GHC.Core.Utils.refineDataAlt`, do /not/ fill in the DEFAULT case with + the data constructor. See + Note [Refine DEFAULT case alternatives] Exception 2, in GHC.Core.Utils. -} warnNoDerivStrat :: Maybe (LDerivStrategy GhcRn) |