diff options
| author | Sylvain Henry <sylvain@haskus.fr> | 2020-06-23 10:01:44 +0200 |
|---|---|---|
| committer | Marge Bot <ben+marge-bot@smart-cactus.org> | 2020-06-27 11:55:59 -0400 |
| commit | 1b3d13b68c95ef9bbeca4437028531d184abcbea (patch) | |
| tree | eed6111120e26030f0ad8ca55144536dcdbe4b1e /compiler/GHC/StgToCmm/Prim.hs | |
| parent | a403eb917bd26caf96c29d67bfe91163b593b2c9 (diff) | |
| download | haskell-1b3d13b68c95ef9bbeca4437028531d184abcbea.tar.gz | |
Fix ghc-bignum exceptions
We must ensure that exceptions are not simplified. Previously we used:
case raiseDivZero of
_ -> 0## -- dummyValue
But it was wrong because the evaluation of `raiseDivZero` was removed and
the dummy value was directly returned. See new Note [ghc-bignum exceptions].
I've also removed the exception triggering primops which were fragile.
We don't need them to be primops, we can have them exported by ghc-prim.
I've also added a test for #18359 which triggered this patch.
Diffstat (limited to 'compiler/GHC/StgToCmm/Prim.hs')
| -rw-r--r-- | compiler/GHC/StgToCmm/Prim.hs | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/compiler/GHC/StgToCmm/Prim.hs b/compiler/GHC/StgToCmm/Prim.hs index fee96f31f8..38c5327570 100644 --- a/compiler/GHC/StgToCmm/Prim.hs +++ b/compiler/GHC/StgToCmm/Prim.hs @@ -1459,9 +1459,6 @@ emitPrimOp dflags = \case CasMutVarOp -> alwaysExternal CatchOp -> alwaysExternal RaiseOp -> alwaysExternal - RaiseDivZeroOp -> alwaysExternal - RaiseUnderflowOp -> alwaysExternal - RaiseOverflowOp -> alwaysExternal RaiseIOOp -> alwaysExternal MaskAsyncExceptionsOp -> alwaysExternal MaskUninterruptibleOp -> alwaysExternal |