Refactor SuggestExtension constructor in GhcHint

This commit refactors the SuggestExtension type constructor of the
GhcHint to be more powerful and flexible. In particular, we can now
embed extra user information (essentially "sugar") to help clarifying
the suggestion. This makes the following possible:

Suggested fix: Perhaps you intended to use GADTs
               or a similar language extension to enable syntax: data T where

We can still give to IDEs and tools a `LangExt.Extension` they can use,
but in the pretty-printed message we can tell the user a bit more on why
such extension is needed.

On top of that, we now have the ability to express conjuctions and
disjunctons, for those cases where GHC suggests to enable "X or Y" and
for the cases where we need "X and Y".

1 files changed, 3 insertions, 3 deletions

diff --git a/compiler/GHC/Tc/Errors/Ppr.hs b/compiler/GHC/Tc/Errors/Ppr.hs
index 97d0a40413..73ef9d9470 100644
--- a/compiler/GHC/Tc/Errors/Ppr.hs
+++ b/compiler/GHC/Tc/Errors/Ppr.hs
@@ -171,13 +171,13 @@ instance Diagnostic TcRnMessage where
     TcRnEmptyRecordUpdate{}
       -> noHints
     TcRnIllegalFieldPunning{}
-      -> [SuggestExtension LangExt.NamedFieldPuns]
+      -> [suggestExtension LangExt.NamedFieldPuns]
     TcRnIllegalWildcardsInRecord{}
-      -> [SuggestExtension LangExt.RecordWildCards]
+      -> [suggestExtension LangExt.RecordWildCards]
     TcRnDuplicateFieldName{}
       -> noHints
     TcRnIllegalViewPattern{}
-      -> [SuggestExtension LangExt.ViewPatterns]
+      -> [suggestExtension LangExt.ViewPatterns]
     TcRnCharLiteralOutOfRange{}
       -> noHints
     TcRnIllegalWildcardsInConstructor{}