diff options
| author | Bartosz Nitka <niteria@gmail.com> | 2016-05-24 02:56:59 -0700 |
|---|---|---|
| committer | Bartosz Nitka <niteria@gmail.com> | 2016-05-24 04:33:21 -0700 |
| commit | 4c6e69d58a300d6ef440d326a3fd29b58b284fa1 (patch) | |
| tree | 6653f56c150c3aa988a96c50359d53f27f2edb01 /compiler/deSugar/Desugar.hs | |
| parent | 8f7d01632cd79957fe42ea37103ca9b91a1c54f5 (diff) | |
| download | haskell-4c6e69d58a300d6ef440d326a3fd29b58b284fa1.tar.gz | |
Document some benign nondeterminism
I've changed the functions to their nonDet equivalents and explained
why they're OK there. This allowed me to remove foldNameSet,
foldVarEnv, foldVarEnv_Directly, foldVarSet and foldUFM_Directly.
Test Plan: ./validate, there should be no change in behavior
Reviewers: simonpj, simonmar, austin, goldfire, bgamari
Reviewed By: bgamari
Subscribers: thomie
Differential Revision: https://phabricator.haskell.org/D2244
GHC Trac Issues: #4012
Diffstat (limited to 'compiler/deSugar/Desugar.hs')
| -rw-r--r-- | compiler/deSugar/Desugar.hs | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/compiler/deSugar/Desugar.hs b/compiler/deSugar/Desugar.hs index 34df427923..75f6a3491b 100644 --- a/compiler/deSugar/Desugar.hs +++ b/compiler/deSugar/Desugar.hs @@ -148,7 +148,9 @@ mk_mod_usage_info pit hsc_env this_mod direct_imports used_names -- ent_map groups together all the things imported and used -- from a particular module ent_map :: ModuleEnv [OccName] - ent_map = foldNameSet add_mv emptyModuleEnv used_names + ent_map = nonDetFoldUFM add_mv emptyModuleEnv used_names + -- nonDetFoldUFM is OK here. If you follow the logic, we sort by OccName + -- in ent_hashs where add_mv name mv_map | isWiredInName name = mv_map -- ignore wired-in names |