diff options
| author | Tamar Christina <tamar@zhox.com> | 2016-01-27 10:20:11 +0100 |
|---|---|---|
| committer | Ben Gamari <ben@smart-cactus.org> | 2016-01-27 10:26:47 +0100 |
| commit | 44a5d51a4892b85c7eba09dcb90ca02245637812 (patch) | |
| tree | 4150f6359e80bcb8ba0aabf99cefc23bcab8f07f /compiler/main/DynFlags.hs | |
| parent | e2bdf03a63b09feabee76e2efd33eb56739324ac (diff) | |
| download | haskell-44a5d51a4892b85c7eba09dcb90ca02245637812.tar.gz | |
Enable RemoteGHCi on Windows
Makes the needed changes to make RemoteGHCi work on Windows.
The approach passes OS Handles areound instead of the Posix Fd
as on Linux.
The reason is that I could not find any real documentation about
the behaviour of Windows w.r.t inheritance and Posix FDs.
The implementation with Fd did not seem to be able to find the Fd
in the child process. Instead I'm using the much better documented
approach of passing inheriting handles.
This requires a small modification to the `process` library.
https://github.com/haskell/process/pull/52
Test Plan: ./validate On Windows x86_64
Reviewers: thomie, erikd, bgamari, simonmar, austin, hvr
Reviewed By: simonmar
Subscribers: #ghc_windows_task_force
Differential Revision: https://phabricator.haskell.org/D1836
GHC Trac Issues: #11100
Diffstat (limited to 'compiler/main/DynFlags.hs')
| -rw-r--r-- | compiler/main/DynFlags.hs | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/compiler/main/DynFlags.hs b/compiler/main/DynFlags.hs index 22c2915960..0e9d4207d4 100644 --- a/compiler/main/DynFlags.hs +++ b/compiler/main/DynFlags.hs @@ -4413,13 +4413,6 @@ makeDynFlagsConsistent dflags = let dflags' = gopt_unset dflags Opt_BuildDynamicToo warn = "-dynamic-too is not supported on Windows" in loop dflags' warn - -- Disalbe -fexternal-interpreter on Windows. This is a temporary measure; - -- all that is missing is the implementation of the interprocess communication - -- which uses pipes on POSIX systems. (#11100) - | os == OSMinGW32 && gopt Opt_ExternalInterpreter dflags - = let dflags' = gopt_unset dflags Opt_ExternalInterpreter - warn = "-fexternal-interpreter is currently not supported on Windows" - in loop dflags' warn | hscTarget dflags == HscC && not (platformUnregisterised (targetPlatform dflags)) = if cGhcWithNativeCodeGen == "YES" |