summaryrefslogtreecommitdiff
path: root/compiler/parser/Parser.y.pp
diff options
context:
space:
mode:
authorRichard Eisenberg <eir@cis.upenn.edu>2012-12-21 20:54:15 -0500
committerRichard Eisenberg <eir@cis.upenn.edu>2012-12-21 20:54:15 -0500
commit8366792eede3c8eb486ff15d8c8e62e9363f1959 (patch)
treeb8ac6d4c9f13a3a8631dac12d3fe75b630f502d1 /compiler/parser/Parser.y.pp
parentd3e2912ac2048346828539e0dfef6c0cefef0d38 (diff)
downloadhaskell-8366792eede3c8eb486ff15d8c8e62e9363f1959.tar.gz
Implement overlapping type family instances.
An ordered, overlapping type family instance is introduced by 'type instance where', followed by equations. See the new section in the user manual (7.7.2.2) for details. The canonical example is Boolean equality at the type level: type family Equals (a :: k) (b :: k) :: Bool type instance where Equals a a = True Equals a b = False A branched family instance, such as this one, checks its equations in order and applies only the first the matches. As explained in the note [Instance checking within groups] in FamInstEnv.lhs, we must be careful not to simplify, say, (Equals Int b) to False, because b might later unify with Int. This commit includes all of the commits on the overlapping-tyfams branch. SPJ requested that I combine all my commits over the past several months into one monolithic commit. The following GHC repos are affected: ghc, testsuite, utils/haddock, libraries/template-haskell, and libraries/dph. Here are some details for the interested: - The definition of CoAxiom has been moved from TyCon.lhs to a new file CoAxiom.lhs. I made this decision because of the number of definitions necessary to support BranchList. - BranchList is a GADT whose type tracks whether it is a singleton list or not-necessarily-a-singleton-list. The reason I introduced this type is to increase static checking of places where GHC code assumes that a FamInst or CoAxiom is indeed a singleton. This assumption takes place roughly 10 times throughout the code. I was worried that a future change to GHC would invalidate the assumption, and GHC might subtly fail to do the right thing. By explicitly labeling CoAxioms and FamInsts as being Unbranched (singleton) or Branched (not-necessarily-singleton), we make this assumption explicit and checkable. Furthermore, to enforce the accuracy of this label, the list of branches of a CoAxiom or FamInst is stored using a BranchList, whose constructors constrain its type index appropriately. I think that the decision to use BranchList is probably the most controversial decision I made from a code design point of view. Although I provide conversions to/from ordinary lists, it is more efficient to use the brList... functions provided in CoAxiom than always to convert. The use of these functions does not wander far from the core CoAxiom/FamInst logic. BranchLists are motivated and explained in the note [Branched axioms] in CoAxiom.lhs. - The CoAxiom type has changed significantly. You can see the new type in CoAxiom.lhs. It uses a CoAxBranch type to track branches of the CoAxiom. Correspondingly various functions producing and consuming CoAxioms had to change, including the binary layout of interface files. - To get branched axioms to work correctly, it is important to have a notion of type "apartness": two types are apart if they cannot unify, and no substitution of variables can ever get them to unify, even after type family simplification. (This is different than the normal failure to unify because of the type family bit.) This notion in encoded in tcApartTys, in Unify.lhs. Because apartness is finer-grained than unification, the tcUnifyTys now calls tcApartTys. - CoreLinting axioms has been updated, both to reflect the new form of CoAxiom and to enforce the apartness rules of branch application. The formalization of the new rules is in docs/core-spec/core-spec.pdf. - The FamInst type (in types/FamInstEnv.lhs) has changed significantly, paralleling the changes to CoAxiom. Of course, this forced minor changes in many files. - There are several new Notes in FamInstEnv.lhs, including one discussing confluent overlap and why we're not doing it. - lookupFamInstEnv, lookupFamInstEnvConflicts, and lookup_fam_inst_env' (the function that actually does the work) have all been more-or-less completely rewritten. There is a Note [lookup_fam_inst_env' implementation] describing the implementation. One of the changes that affects other files is to change the type of matches from a pair of (FamInst, [Type]) to a new datatype (which now includes the index of the matching branch). This seemed a better design. - The TySynInstD constructor in Template Haskell was updated to use the new datatype TySynEqn. I also bumped the TH version number, requiring changes to DPH cabal files. (That's why the DPH repo has an overlapping-tyfams branch.) - As SPJ requested, I refactored some of the code in HsDecls: * splitting up TyDecl into SynDecl and DataDecl, correspondingly changing HsTyDefn to HsDataDefn (with only one constructor) * splitting FamInstD into TyFamInstD and DataFamInstD and splitting FamInstDecl into DataFamInstDecl and TyFamInstDecl * making the ClsInstD take a ClsInstDecl, for parallelism with InstDecl's other constructors * changing constructor TyFamily into FamDecl * creating a FamilyDecl type that stores the details for a family declaration; this is useful because FamilyDecls can appear in classes but other decls cannot * restricting the associated types and associated type defaults for a * class to be the new, more restrictive types * splitting cid_fam_insts into cid_tyfam_insts and cid_datafam_insts, according to the new types * perhaps one or two more that I'm overlooking None of these changes has far-reaching implications. - The user manual, section 7.7.2.2, is updated to describe the new type family instances.
Diffstat (limited to 'compiler/parser/Parser.y.pp')
-rw-r--r--compiler/parser/Parser.y.pp72
1 files changed, 48 insertions, 24 deletions
diff --git a/compiler/parser/Parser.y.pp b/compiler/parser/Parser.y.pp
index 510d7c42ae..e3f4994166 100644
--- a/compiler/parser/Parser.y.pp
+++ b/compiler/parser/Parser.y.pp
@@ -642,7 +642,8 @@ ty_decl :: { LTyClDecl RdrName }
| 'type' 'family' type opt_kind_sig
-- Note the use of type for the head; this allows
-- infix type constructors to be declared
- {% mkTyFamily (comb3 $1 $3 $4) TypeFamily $3 (unLoc $4) }
+ {% do { L loc decl <- mkFamDecl (comb3 $1 $3 $4) TypeFamily $3 (unLoc $4)
+ ; return (L loc (FamDecl decl)) } }
-- ordinary data type or newtype declaration
| data_or_newtype capi_ctype tycl_hdr constrs deriving
@@ -662,26 +663,30 @@ ty_decl :: { LTyClDecl RdrName }
-- data/newtype family
| 'data' 'family' type opt_kind_sig
- {% mkTyFamily (comb3 $1 $2 $4) DataFamily $3 (unLoc $4) }
+ {% do { L loc decl <- mkFamDecl (comb3 $1 $2 $4) DataFamily $3 (unLoc $4)
+ ; return (L loc (FamDecl decl)) } }
inst_decl :: { LInstDecl RdrName }
: 'instance' inst_type where_inst
- { let (binds, sigs, _, ats, _) = cvBindsAndSigs (unLoc $3)
- in L (comb3 $1 $2 $3) (ClsInstD { cid_poly_ty = $2, cid_binds = binds
- , cid_sigs = sigs, cid_fam_insts = ats }) }
+ { let (binds, sigs, _, ats, adts, _) = cvBindsAndSigs (unLoc $3) in
+ let cid = ClsInstDecl { cid_poly_ty = $2, cid_binds = binds
+ , cid_sigs = sigs, cid_tyfam_insts = ats
+ , cid_datafam_insts = adts }
+ in L (comb3 $1 $2 $3) (ClsInstD { cid_inst = cid }) }
-- type instance declarations
- | 'type' 'instance' type '=' ctype
- -- Note the use of type for the head; this allows
- -- infix type constructors and type patterns
- {% do { L loc d <- mkFamInstSynonym (comb2 $1 $5) $3 $5
- ; return (L loc (FamInstD { lid_inst = d })) } }
+ | 'type' 'instance' ty_fam_inst_eqn
+ {% do { L loc tfi <- mkTyFamInst (comb2 $1 $3) $3
+ ; return (L loc (TyFamInstD { tfid_inst = tfi })) } }
+
+ | 'type' 'instance' 'where' ty_fam_inst_eqn_list
+ { LL (TyFamInstD { tfid_inst = mkTyFamInstGroup (unLoc $4) }) }
-- data/newtype instance declaration
| data_or_newtype 'instance' tycl_hdr constrs deriving
{% do { L loc d <- mkFamInstData (comb4 $1 $3 $4 $5) (unLoc $1) Nothing $3
Nothing (reverse (unLoc $4)) (unLoc $5)
- ; return (L loc (FamInstD { lid_inst = d })) } }
+ ; return (L loc (DataFamInstD { dfid_inst = d })) } }
-- GADT instance declaration
| data_or_newtype 'instance' tycl_hdr opt_kind_sig
@@ -689,8 +694,25 @@ inst_decl :: { LInstDecl RdrName }
deriving
{% do { L loc d <- mkFamInstData (comb4 $1 $3 $5 $6) (unLoc $1) Nothing $3
(unLoc $4) (unLoc $5) (unLoc $6)
- ; return (L loc (FamInstD { lid_inst = d })) } }
+ ; return (L loc (DataFamInstD { dfid_inst = d })) } }
+-- Type instance groups
+
+ty_fam_inst_eqn_list :: { Located [LTyFamInstEqn RdrName] }
+ : '{' ty_fam_inst_eqns '}' { LL (unLoc $2) }
+ | vocurly ty_fam_inst_eqns close { $2 }
+
+ty_fam_inst_eqns :: { Located [LTyFamInstEqn RdrName] }
+ : ty_fam_inst_eqn ';' ty_fam_inst_eqns { LL ($1 : unLoc $3) }
+ | ty_fam_inst_eqns ';' { LL (unLoc $1) }
+ | ty_fam_inst_eqn { LL [$1] }
+
+ty_fam_inst_eqn :: { LTyFamInstEqn RdrName }
+ : type '=' ctype
+ -- Note the use of type for the head; this allows
+ -- infix type constructors and type patterns
+ {% mkTyFamInstEqn (comb2 $1 $3) $1 $3 }
+
-- Associated type family declarations
--
-- * They have a different syntax than on the toplevel (no family special
@@ -705,31 +727,32 @@ at_decl_cls :: { LHsDecl RdrName }
: 'type' type opt_kind_sig
-- Note the use of type for the head; this allows
-- infix type constructors to be declared.
- {% do { L loc decl <- mkTyFamily (comb3 $1 $2 $3) TypeFamily $2 (unLoc $3)
- ; return (L loc (TyClD decl)) } }
+ {% do { L loc decl <- mkFamDecl (comb3 $1 $2 $3) TypeFamily $2 (unLoc $3)
+ ; return (L loc (TyClD (FamDecl decl))) } }
| 'data' type opt_kind_sig
- {% do { L loc decl <- mkTyFamily (comb3 $1 $2 $3) DataFamily $2 (unLoc $3)
- ; return (L loc (TyClD decl)) } }
+ {% do { L loc decl <- mkFamDecl (comb3 $1 $2 $3) DataFamily $2 (unLoc $3)
+ ; return (L loc (TyClD (FamDecl decl))) } }
-- default type instance
- | 'type' type '=' ctype
+ | 'type' ty_fam_inst_eqn
-- Note the use of type for the head; this allows
-- infix type constructors and type patterns
- {% do { L loc fid <- mkFamInstSynonym (comb2 $1 $4) $2 $4
- ; return (L loc (InstD (FamInstD { lid_inst = fid }))) } }
+ {% do { L loc tfi <- mkTyFamInst (comb2 $1 $2) $2
+ ; return (L loc (InstD (TyFamInstD { tfid_inst = tfi }))) } }
-- Associated type instances
--
-at_decl_inst :: { LFamInstDecl RdrName }
+at_decl_inst :: { LTyFamInstDecl RdrName }
-- type instance declarations
- : 'type' type '=' ctype
+ : 'type' ty_fam_inst_eqn
-- Note the use of type for the head; this allows
-- infix type constructors and type patterns
- {% mkFamInstSynonym (comb2 $1 $4) $2 $4 }
+ {% mkTyFamInst (comb2 $1 $2) $2 }
+adt_decl_inst :: { LDataFamInstDecl RdrName }
-- data/newtype instance declaration
- | data_or_newtype capi_ctype tycl_hdr constrs deriving
+ : data_or_newtype capi_ctype tycl_hdr constrs deriving
{% mkFamInstData (comb4 $1 $3 $4 $5) (unLoc $1) $2 $3
Nothing (reverse (unLoc $4)) (unLoc $5) }
@@ -808,7 +831,8 @@ where_cls :: { Located (OrdList (LHsDecl RdrName)) } -- Reversed
-- Declarations in instance bodies
--
decl_inst :: { Located (OrdList (LHsDecl RdrName)) }
-decl_inst : at_decl_inst { LL (unitOL (L1 (InstD (FamInstD { lid_inst = unLoc $1 })))) }
+decl_inst : at_decl_inst { LL (unitOL (L1 (InstD (TyFamInstD { tfid_inst = unLoc $1 })))) }
+ | adt_decl_inst { LL (unitOL (L1 (InstD (DataFamInstD { dfid_inst = unLoc $1 })))) }
| decl { $1 }
decls_inst :: { Located (OrdList (LHsDecl RdrName)) } -- Reversed