diff options
| author | Ryan Scott <ryan.gl.scott@gmail.com> | 2018-08-28 22:58:52 +0200 |
|---|---|---|
| committer | Krzysztof Gogolewski <krz.gogolewski@gmail.com> | 2018-08-28 22:58:53 +0200 |
| commit | 102284e72f8d29599803aa72ccec180db28e72c8 (patch) | |
| tree | 98cdd246b06eb3af83eaf61d9f6eea469b1f25d4 /compiler/types | |
| parent | 34b8e613606653187f1ffae36a83e33f0c673720 (diff) | |
| download | haskell-102284e72f8d29599803aa72ccec180db28e72c8.tar.gz | |
Rename kind vars in left-to-right order in bindHsQTyVars
Summary:
When renaming kind variables in an `LHsQTyVars`, we were
erroneously putting all of the kind variables in the binders
//after// the kind variables in the body, resulting in #15568. The
fix is simple: just swap the order of these two around.
Test Plan: make test TEST=T15568
Reviewers: simonpj, bgamari, goldfire
Reviewed By: goldfire
Subscribers: goldfire, rwbarton, carter
GHC Trac Issues: #15568
Differential Revision: https://phabricator.haskell.org/D5108
Diffstat (limited to 'compiler/types')
| -rw-r--r-- | compiler/types/Type.hs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/compiler/types/Type.hs b/compiler/types/Type.hs index 9b4aec670d..33cdae3e63 100644 --- a/compiler/types/Type.hs +++ b/compiler/types/Type.hs @@ -1912,7 +1912,7 @@ predTypeEqRel ty -- It is also meant to be stable: that is, variables should not -- be reordered unnecessarily. The implementation of this -- has been observed to be stable, though it is not proven to --- be so. See also Note [Ordering of implicit variables] in HsTypes +-- be so. See also Note [Ordering of implicit variables] in RnTypes toposortTyVars :: [TyCoVar] -> [TyCoVar] toposortTyVars tvs = reverse $ [ node_payload node | node <- topologicalSortG $ |