diff options
| author | Bartosz Nitka <niteria@gmail.com> | 2016-06-14 03:28:30 -0700 |
|---|---|---|
| committer | Bartosz Nitka <niteria@gmail.com> | 2016-06-23 07:53:12 -0700 |
| commit | 35d1564cea2e611a4fecf24f09eff83f8a55af1c (patch) | |
| tree | 5d46f89500052d356bf68e2befd6bf854550193a /compiler/vectorise | |
| parent | 7fc20b02b20c97209b97f0e36d34a4ef40f537a4 (diff) | |
| download | haskell-35d1564cea2e611a4fecf24f09eff83f8a55af1c.tar.gz | |
Provide Uniquable version of SCC
We want to remove the `Ord Unique` instance because there's
no way to implement it in deterministic way and it's too
easy to use by accident.
We sometimes compute SCC for datatypes whose Ord instance
is implemented in terms of Unique. The Ord constraint on
SCC is just an artifact of some internal data structures.
We can have an alternative implementation with a data
structure that uses Uniquable instead.
This does exactly that and I'm pleased that I didn't have
to introduce any duplication to do that.
Test Plan:
./validate
I looked at performance tests and it's a tiny bit better.
Reviewers: bgamari, simonmar, ezyang, austin, goldfire
Subscribers: thomie
Differential Revision: https://phabricator.haskell.org/D2359
GHC Trac Issues: #4012
Diffstat (limited to 'compiler/vectorise')
| -rw-r--r-- | compiler/vectorise/Vectorise/Type/Classify.hs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/compiler/vectorise/Vectorise/Type/Classify.hs b/compiler/vectorise/Vectorise/Type/Classify.hs index 75d43d4e36..7963ae7375 100644 --- a/compiler/vectorise/Vectorise/Type/Classify.hs +++ b/compiler/vectorise/Vectorise/Type/Classify.hs @@ -96,7 +96,7 @@ type TyConGroup = ([TyCon], UniqSet TyCon) -- Compute mutually recursive groups of tycons in topological order. -- tyConGroups :: [TyCon] -> [TyConGroup] -tyConGroups tcs = map mk_grp (stronglyConnCompFromEdgedVertices edges) +tyConGroups tcs = map mk_grp (stronglyConnCompFromEdgedVerticesUniq edges) where edges = [((tc, ds), tc, nonDetEltsUFM ds) | tc <- tcs , let ds = tyConsOfTyCon tc] |