diff options
| author | Vladislav Zavialov <vlad.z.4096@gmail.com> | 2023-01-14 14:41:39 +0300 |
|---|---|---|
| committer | Marge Bot <ben+marge-bot@smart-cactus.org> | 2023-01-18 01:56:22 -0500 |
| commit | e9c0537cfbf7b47c64f592f529e402358b66ca7f (patch) | |
| tree | a1e9fe1b5dadf437f7b8bf5dada0d11e4c7d8283 /compiler | |
| parent | ee9b78aa17e1eb81b3c4aa6a5ce324de49530e92 (diff) | |
| download | haskell-e9c0537cfbf7b47c64f592f529e402358b66ca7f.tar.gz | |
Enable -Wstar-is-type by default (#22759)
Following the plan in GHC Proposal #143 "Remove the * kind syntax",
which states:
In the next release (or 3 years in), enable -fwarn-star-is-type by default.
The "next release" happens to be 9.6.1
I also moved the T21583 test case from should_fail to should_compile,
because the only reason it was failing was -Werror=compat in our test
suite configuration.
Diffstat (limited to 'compiler')
| -rw-r--r-- | compiler/GHC/Driver/Flags.hs | 3 | ||||
| -rw-r--r-- | compiler/GHC/Tc/Errors/Types.hs | 2 |
2 files changed, 2 insertions, 3 deletions
diff --git a/compiler/GHC/Driver/Flags.hs b/compiler/GHC/Driver/Flags.hs index 4f656041df..634718ae7e 100644 --- a/compiler/GHC/Driver/Flags.hs +++ b/compiler/GHC/Driver/Flags.hs @@ -822,6 +822,7 @@ standardWarnings -- see Note [Documenting warning flags] Opt_WarnUnrecognisedWarningFlags, Opt_WarnSimplifiableClassConstraints, Opt_WarnStarBinder, + Opt_WarnStarIsType, Opt_WarnInaccessibleCode, Opt_WarnSpaceAfterBang, Opt_WarnNonCanonicalMonadInstances, @@ -863,7 +864,6 @@ minusWallOpts Opt_WarnMissingPatternSynonymSignatures, Opt_WarnUnusedRecordWildcards, Opt_WarnRedundantRecordWildcards, - Opt_WarnStarIsType, Opt_WarnIncompleteUniPatterns, Opt_WarnIncompletePatternsRecUpd ] @@ -881,7 +881,6 @@ minusWcompatOpts :: [WarningFlag] minusWcompatOpts = [ Opt_WarnSemigroup , Opt_WarnNonCanonicalMonoidInstances - , Opt_WarnStarIsType , Opt_WarnCompatUnqualifiedImports , Opt_WarnTypeEqualityOutOfScope ] diff --git a/compiler/GHC/Tc/Errors/Types.hs b/compiler/GHC/Tc/Errors/Types.hs index 65701f9fee..add396957c 100644 --- a/compiler/GHC/Tc/Errors/Types.hs +++ b/compiler/GHC/Tc/Errors/Types.hs @@ -2578,7 +2578,7 @@ data TcRnMessage where testsuite/tests/typecheck/should_compile/tc078 testsuite/tests/typecheck/should_compile/tc161 testsuite/tests/typecheck/should_fail/T5051 - testsuite/tests/typecheck/should_fail/T21583 + testsuite/tests/typecheck/should_compile/T21583 testsuite/tests/backpack/should_compile/bkp47 testsuite/tests/backpack/should_fail/bkpfail25 testsuite/tests/parser/should_compile/T2245 |