diff options
author | Ryan Scott <ryan.gl.scott@gmail.com> | 2016-09-05 15:45:38 -0400 |
---|---|---|
committer | Ryan Scott <ryan.gl.scott@gmail.com> | 2016-09-05 15:45:40 -0400 |
commit | 34010dbe77ac405da6c671c3feb3573d0d025379 (patch) | |
tree | c748001a49caf34150a108d8948c8be092cfc49c /distrib | |
parent | 4ff4929cbaab21a3ca867abbc1bd24ff3287a16f (diff) | |
download | haskell-34010dbe77ac405da6c671c3feb3573d0d025379.tar.gz |
Derive the Generic instance in perf/compiler/T5642
Summary:
For some inexplicable reason, the `Generic` instance in
`perf/compiler/T5642` is written out entirely by hand. This is not only
strange, since Trac #5642 is about derived `Generic` instances, but it also
annoying to maintain, since it requires manually changing a bunch of code
whenever the algorithm behind `deriving Generic` changes. (See D2304 for a
recent example of this.)
It seems more sensible to just derive the `Generic` instance. It shifts the
goalposts of what allocations we're measuring a bit, since we no longer have
to parse a large amount of code (and as a knock-on effect, the allocations go
down a bit). But I think this program is morally equivalent to what we were
benchmarking before, so it's not too unreasonable to change.
Test Plan: make test TEST=T5642
Reviewers: austin, thomie, bgamari
Reviewed By: bgamari
Differential Revision: https://phabricator.haskell.org/D2511
GHC Trac Issues: #5642
Diffstat (limited to 'distrib')
0 files changed, 0 insertions, 0 deletions