diff options
| author | George Karachalias <george.karachalias@gmail.com> | 2016-01-05 15:59:49 +0100 |
|---|---|---|
| committer | Ben Gamari <ben@smart-cactus.org> | 2016-01-05 22:08:13 +0100 |
| commit | 77494fa9fa34c1a831caabc194e855167de0c2d9 (patch) | |
| tree | 4e9881a040cf59468b570fb0f328a103628cc770 /docs | |
| parent | cdeefa44ac8e2452a691708715bd2157a7bf3f0e (diff) | |
| download | haskell-77494fa9fa34c1a831caabc194e855167de0c2d9.tar.gz | |
Remove -Wtoo-many-guards from default flags (fixes #11316)
Since #11316 indicates that having flag `-Wtoo-many-guards`
enabled by default causes issues, the simplest thing is to
remove it. This patch removes it from the default list, it
updates the docs and removes the suppression flags for
`T783` and `types/OptCoercion.hs`
Test Plan: validate
Reviewers: bgamari, austin, goldfire
Subscribers: thomie
Differential Revision: https://phabricator.haskell.org/D1737
GHC Trac Issues: #11316
Diffstat (limited to 'docs')
| -rw-r--r-- | docs/users_guide/8.0.1-notes.rst | 3 | ||||
| -rw-r--r-- | docs/users_guide/using-warnings.rst | 11 |
2 files changed, 7 insertions, 7 deletions
diff --git a/docs/users_guide/8.0.1-notes.rst b/docs/users_guide/8.0.1-notes.rst index 1e47d19649..08f4800690 100644 --- a/docs/users_guide/8.0.1-notes.rst +++ b/docs/users_guide/8.0.1-notes.rst @@ -248,8 +248,7 @@ Compiler - Added the ``-Wtoo-many-guards`` flag. When enabled, this will issue a warning if a pattern match contains too many guards (over 20 at the - moment). It is enabled by default but makes a difference only if pattern - match checking is also enabled. + moment). Makes a difference only if pattern match checking is also enabled. - Added the ``-ffull-guard-reasoning`` flag. When enabled, pattern match checking tries its best to reason about guards. Since the additional diff --git a/docs/users_guide/using-warnings.rst b/docs/users_guide/using-warnings.rst index 619f7011d7..bc126887fc 100644 --- a/docs/users_guide/using-warnings.rst +++ b/docs/users_guide/using-warnings.rst @@ -545,14 +545,15 @@ of ``-W(no-)*``. The option ``-Wtoo-many-guards`` warns about places where a pattern match contains too many guards (over 20 at the moment). - It is enabled by default but has an effect only if any form of - exhaustivness/overlapping checking is enabled (one of + It has an effect only if any form of exhaustivness/overlapping + checking is enabled (one of ``-Wincomplete-patterns``, ``-Wincomplete-uni-patterns``, ``-Wincomplete-record-updates``, - ``-Woverlapping-patterns``). The warning can be suppressed by - enabling either ``-Wno-too-many-guards``, which just hides the - warning, or ``-ffull-guard-reasoning``. + ``-Woverlapping-patterns``). When enabled, the warning can be + suppressed by enabling either ``-Wno-too-many-guards``, which just + hides the warning, or ``-ffull-guard-reasoning`` which runs the + full check, independently of the number of guards. ``-ffull-guard-reasoning`` .. index:: |