diff options
author | Simon Marlow <marlowsd@gmail.com> | 2018-05-10 17:39:53 +0100 |
---|---|---|
committer | Simon Marlow <marlowsd@gmail.com> | 2018-05-10 17:39:53 +0100 |
commit | 87e169a30dae11444a90b4d37c3d30e57b9c275b (patch) | |
tree | c307b10d0d4169a8e0ab76788f321c14a1bab964 /ghc | |
parent | e5bb515e651e33fadc90c016c28553f2e9d8a956 (diff) | |
download | haskell-87e169a30dae11444a90b4d37c3d30e57b9c275b.tar.gz |
Revert "Add -fghci-leak-check to check for space leaks"
This reverts commit 5fe6aaa3756cda654374ebfd883fa8f064ff64a4.
Diffstat (limited to 'ghc')
-rw-r--r-- | ghc/GHCi/Leak.hs | 59 | ||||
-rw-r--r-- | ghc/GHCi/UI.hs | 15 | ||||
-rw-r--r-- | ghc/ghc-bin.cabal.in | 1 |
3 files changed, 1 insertions, 74 deletions
diff --git a/ghc/GHCi/Leak.hs b/ghc/GHCi/Leak.hs deleted file mode 100644 index 3f64b5dcf0..0000000000 --- a/ghc/GHCi/Leak.hs +++ /dev/null @@ -1,59 +0,0 @@ -{-# LANGUAGE RecordWildCards, LambdaCase #-} -module GHCi.Leak - ( LeakIndicators - , getLeakIndicators - , checkLeakIndicators - ) where - -import Control.Monad -import GHC -import Outputable -import HscTypes -import UniqDFM -import System.Mem -import System.Mem.Weak - --- Checking for space leaks in GHCi. See #15111, and the --- -fghci-leak-check flag. - -data LeakIndicators = LeakIndicators [LeakModIndicators] - -data LeakModIndicators = LeakModIndicators - { leakMod :: Weak HomeModInfo - , leakIface :: Weak ModIface - , leakDetails :: Weak ModDetails - , leakLinkable :: Maybe (Weak Linkable) - } - --- | Grab weak references to some of the data structures representing --- the currently loaded modules. -getLeakIndicators :: HscEnv -> IO LeakIndicators -getLeakIndicators HscEnv{..} = - fmap LeakIndicators $ - forM (eltsUDFM hsc_HPT) $ \hmi@HomeModInfo{..} -> do - leakMod <- mkWeakPtr hmi Nothing - leakIface <- mkWeakPtr hm_iface Nothing - leakDetails <- mkWeakPtr hm_details Nothing - leakLinkable <- mapM (`mkWeakPtr` Nothing) hm_linkable - return $ LeakModIndicators{..} - --- | Look at the LeakIndicators collected by an earlier call to --- `getLeakIndicators`, and print messasges if any of them are still --- alive. -checkLeakIndicators :: DynFlags -> LeakIndicators -> IO () -checkLeakIndicators dflags (LeakIndicators leakmods) = do - performGC - forM_ leakmods $ \LeakModIndicators{..} -> do - deRefWeak leakMod >>= \case - Nothing -> return () - Just hmi -> - report ("HomeModInfo for " ++ - showSDoc dflags (ppr (mi_module (hm_iface hmi)))) (Just hmi) - deRefWeak leakIface >>= report "ModIface" - deRefWeak leakDetails >>= report "ModDetails" - forM_ leakLinkable $ \l -> deRefWeak l >>= report "Linkable" - where - report :: String -> Maybe a -> IO () - report _ Nothing = return () - report msg (Just _) = - putStrLn ("-fghci-leak-check: " ++ msg ++ " is still alive!") diff --git a/ghc/GHCi/UI.hs b/ghc/GHCi/UI.hs index c97fb01033..349368b6d7 100644 --- a/ghc/GHCi/UI.hs +++ b/ghc/GHCi/UI.hs @@ -134,8 +134,6 @@ import GHC.IO.Exception ( IOErrorType(InvalidArgument) ) import GHC.IO.Handle ( hFlushAll ) import GHC.TopHandler ( topHandler ) -import GHCi.Leak - ----------------------------------------------------------------------------- data GhciSettings = GhciSettings { @@ -1648,14 +1646,6 @@ loadModule' files = do -- require some re-working of the GHC interface, so we'll leave it -- as a ToDo for now. - hsc_env <- GHC.getSession - - -- Grab references to the currently loaded modules so that we can - -- see if they leak. - leak_indicators <- if gopt Opt_GhciLeakCheck (hsc_dflags hsc_env) - then liftIO $ getLeakIndicators hsc_env - else return (panic "no leak indicators") - -- unload first _ <- GHC.abandonAll lift discardActiveBreakPoints @@ -1663,10 +1653,7 @@ loadModule' files = do _ <- GHC.load LoadAllTargets GHC.setTargets targets - success <- doLoadAndCollectInfo False LoadAllTargets - when (gopt Opt_GhciLeakCheck (hsc_dflags hsc_env)) $ - liftIO $ checkLeakIndicators (hsc_dflags hsc_env) leak_indicators - return success + doLoadAndCollectInfo False LoadAllTargets -- | @:add@ command addModule :: [FilePath] -> InputT GHCi () diff --git a/ghc/ghc-bin.cabal.in b/ghc/ghc-bin.cabal.in index 6c12941630..12812ef07c 100644 --- a/ghc/ghc-bin.cabal.in +++ b/ghc/ghc-bin.cabal.in @@ -61,7 +61,6 @@ Executable ghc CPP-Options: -DGHCI GHC-Options: -fno-warn-name-shadowing Other-Modules: - GHCi.Leak GHCi.UI GHCi.UI.Info GHCi.UI.Monad |