summaryrefslogtreecommitdiff
path: root/ghc
diff options
context:
space:
mode:
authorAustin Seipp <austin@well-typed.com>2014-02-18 05:20:15 -0600
committerAustin Seipp <austin@well-typed.com>2014-02-18 05:20:15 -0600
commit642bba349fda1508aa136f7169c0ba63fb00a6f9 (patch)
tree8e51958373116dff7b1fbceeaa3468151e69a528 /ghc
parent89d2c048c81020a701ac94d949b4d6f1ced37cfa (diff)
downloadhaskell-642bba349fda1508aa136f7169c0ba63fb00a6f9.tar.gz
Revert "Add comments explaining #8754"
This reverts commit b626c3d4ce0e66216705ba8355c914dc809e3fe7.
Diffstat (limited to 'ghc')
-rw-r--r--ghc/Main.hs21
1 files changed, 1 insertions, 20 deletions
diff --git a/ghc/Main.hs b/ghc/Main.hs
index 0011aa986f..1aa65531a3 100644
--- a/ghc/Main.hs
+++ b/ghc/Main.hs
@@ -77,7 +77,7 @@ import Data.Maybe
main :: IO ()
main = do
- defaultsHook -- See Note [-Bsymbolic and hooks]
+ defaultsHook
hSetBuffering stdout LineBuffering
hSetBuffering stderr LineBuffering
GHC.defaultErrorHandler defaultFatalMessager defaultFlushOut $ do
@@ -821,23 +821,4 @@ unknownFlagsErr fs = throwGhcException $ UsageError $ concatMap oneError fs
[] -> ""
suggs -> "did you mean one of:\n" ++ unlines (map (" " ++) suggs))
-{- Note [-Bsymbolic and hooks]
-~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
--Bsymbolic is a flag that prevents the binding of references to global
-symbols to symbols outside the shared library being compiled (see `man
-ld`). When dynamically linking, we don't use -Bsymbolic on the RTS
-package: that is because we want hooks to be overridden by the user,
-we don't want to constrain them to the RTS package.
-
-Unfortunately this seems to have broken somehow on OS X: as a result,
-defaultHooks (in hschooks.c) is not called, which does not initialize
-the GC stats. As a result, this breaks things like `:set +s` in GHCi
-(#8754). As a hacky workaround, we instead call 'defaultHooks'
-directly to initalize the flags in the RTS.
-
-A biproduct of this, I believe, is that hooks are likely broken on OS
-X when dynamically linking. But this probably doesn't affect most
-people since we're linking GHC dynamically, but most things themselves
-link statically.
--}
foreign import ccall safe "defaultsHook" defaultsHook :: IO ()