diff options
| author | John Ericson <git@JohnEricson.me> | 2019-10-07 23:06:26 -0400 |
|---|---|---|
| committer | Marge Bot <ben+marge-bot@smart-cactus.org> | 2019-10-12 06:32:18 -0400 |
| commit | c2290596f10ce732be85503d3ef0f0b50b7e925a (patch) | |
| tree | 7206d141fd205c0c6fe6a0d54eb30f1171b23f06 /hadrian/src/Settings/Builders/Common.hs | |
| parent | 166e1c2adf73b69bfbbec81e98a78814a031ddc7 (diff) | |
| download | haskell-c2290596f10ce732be85503d3ef0f0b50b7e925a.tar.gz | |
Simplify Configure in a few ways
- No need to distinguish between gcc-llvm and clang. First of all,
gcc-llvm is quite old and surely unmaintained by now. Second of all,
none of the code actually care about that distinction!
Now, it does make sense to consider C multiple frontends for LLVMs in
the form of clang vs clang-cl (same clang, yes, but tweaked
interface). But this is better handled in terms of "gccish vs
mvscish" and "is LLVM", yielding 4 combinations. Therefore, I don't
think it is useful saving the existing code for that.
- Get the remaining CC_LLVM_BACKEND, and also TABLES_NEXT_TO_CODE in
mk/config.h the normal way, rather than hacking it post-hoc. No point
keeping these special cases around for now reason.
- Get rid of hand-rolled `die` function and just use `AC_MSG_ERROR`.
- Abstract check + flag override for unregisterised and tables next to
code.
Oh, and as part of the above I also renamed/combined some variables
where it felt appropriate.
- GccIsClang -> CcLlvmBackend. This is for `AC_SUBST`, like the other
Camal case ones. It was never about gcc-llvm, or Apple's renamed clang,
to be clear.
- llvm_CC_FLAVOR -> CC_LLVM_BACKEND. This is for `AC_DEFINE`, like the
other all-caps snake case ones. llvm_CC_FLAVOR was just silly
indirection *and* an odd name to boot.
Diffstat (limited to 'hadrian/src/Settings/Builders/Common.hs')
| -rw-r--r-- | hadrian/src/Settings/Builders/Common.hs | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/hadrian/src/Settings/Builders/Common.hs b/hadrian/src/Settings/Builders/Common.hs index 7d9e0fe716..2c41d92493 100644 --- a/hadrian/src/Settings/Builders/Common.hs +++ b/hadrian/src/Settings/Builders/Common.hs @@ -53,9 +53,9 @@ cArgs = mempty cWarnings :: Args cWarnings = mconcat [ arg "-Wall" - , flag GccIsClang ? arg "-Wno-unknown-pragmas" - , notM (flag GccIsClang) ? not windowsHost ? arg "-Werror=unused-but-set-variable" - , notM (flag GccIsClang) ? arg "-Wno-error=inline" ] + , flag CcLlvmBackend ? arg "-Wno-unknown-pragmas" + , notM (flag CcLlvmBackend) ? not windowsHost ? arg "-Werror=unused-but-set-variable" + , notM (flag CcLlvmBackend) ? arg "-Wno-error=inline" ] packageDatabaseArgs :: Args packageDatabaseArgs = do |