diff options
author | Michael Sloan <mgsloan@gmail.com> | 2019-03-14 15:47:44 -0700 |
---|---|---|
committer | Matthew Pickering <matthewtpickering@gmail.com> | 2019-05-24 16:55:07 +0100 |
commit | d9dfbde30aa11afc87f25b73dc2d154a46ca24d4 (patch) | |
tree | 6a8172d4cbbbeb1533e3ca8146a107938e9ae173 /includes/CodeGen.Platform.hs | |
parent | c931f2561207aa06f1750827afbb68fbee241c6f (diff) | |
download | haskell-d9dfbde30aa11afc87f25b73dc2d154a46ca24d4.tar.gz |
Add PlainPanic for throwing exceptions without depending on pprint
This commit splits out a subset of GhcException which do not depend on
pretty printing (SDoc), as a new datatype called
PlainGhcException. These exceptions can be caught as GhcException,
because 'fromException' will convert them.
The motivation for this change is that that the Panic module
transitively depends on many modules, primarily due to pretty printing
code. It's on the order of about 130 modules. This large set of
dependencies has a few implications:
1. To avoid cycles / use of boot files, these dependencies cannot
throw GhcException.
2. There are some utility modules that use UnboxedTuples and also use
`panic`. This means that when loading GHC into GHCi, about 130
additional modules would need to be compiled instead of
interpreted. Splitting the non-pprint exception throwing into a new
module resolves this issue. See #13101
Diffstat (limited to 'includes/CodeGen.Platform.hs')
-rw-r--r-- | includes/CodeGen.Platform.hs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/includes/CodeGen.Platform.hs b/includes/CodeGen.Platform.hs index 867dd14fb0..27a9324438 100644 --- a/includes/CodeGen.Platform.hs +++ b/includes/CodeGen.Platform.hs @@ -2,7 +2,7 @@ import CmmExpr #if !(defined(MACHREGS_i386) || defined(MACHREGS_x86_64) \ || defined(MACHREGS_sparc) || defined(MACHREGS_powerpc)) -import Panic +import PlainPanic #endif import Reg |