diff options
author | Ben Gamari <bgamari.foss@gmail.com> | 2014-08-15 11:11:17 -0400 |
---|---|---|
committer | Reid Barton <rwbarton@gmail.com> | 2014-08-15 11:11:18 -0400 |
commit | 5895f2b8ffba72a8393e9f712461e6e5ed7ceced (patch) | |
tree | 40daf2661079c8efa502bc19aa7ae6a1dca638e6 /includes/rts/storage/ClosureMacros.h | |
parent | 03a8003e5d3aec97b3a14b2d3c774aad43e0456e (diff) | |
download | haskell-5895f2b8ffba72a8393e9f712461e6e5ed7ceced.tar.gz |
LlvmMangler: Be more selective when mangling object types
Summary:
We previously did a wholesale replace of `%function` to `%object` to
mangle object `.type` annotations. This is bad as it can end up
replacing appearances of `"%function"` in the user's code. We now look
for a proper `.type` keyword before performing the replacement.
Thanks to @rwbarton for pointing out the bug.
Test Plan:
Previously,
$ echo 'main = putStrLn "@function"' > test.hs
$ ghc -fllvm test.hs
$ ./test
@object
Now,
$ echo 'main = putStrLn "@function"' > test.hs
$ ghc -fllvm test.hs
$ ./test
@function
Reviewers: rwbarton, austin
Reviewed By: rwbarton, austin
Subscribers: phaskell, simonmar, relrod, ezyang, carter
Differential Revision: https://phabricator.haskell.org/D150
GHC Trac Issues: #9439
Diffstat (limited to 'includes/rts/storage/ClosureMacros.h')
0 files changed, 0 insertions, 0 deletions