diff options
| author | Alexander Vershilov <alexander.vershilov@tweag.io> | 2015-01-14 17:58:30 -0600 |
|---|---|---|
| committer | Austin Seipp <austin@well-typed.com> | 2015-01-16 10:15:45 -0600 |
| commit | fffbf0627c2c2ee4bc49f9d26a226b39a066945e (patch) | |
| tree | a3f74945126cef5faa1c28f524097a20ac5d4cd5 /includes | |
| parent | 6392df07e89304a4daeb1af379c051b03a39cda7 (diff) | |
| download | haskell-fffbf0627c2c2ee4bc49f9d26a226b39a066945e.tar.gz | |
Trac #9878: Make the static form illegal in interpreted mode.
Summary:
The entries of the static pointers table are expected to exist as
object code. Thus we have ghci complain with an intelligible error
message if the static form is used in interpreted mode.
It also includes a fix to keysHashTable in Hash.c which could cause a
crash. The iteration of the hashtable internals was incorrect. This
patch has the function keysHashTable imitate the iteration in
freeHashTable.
Finally, we submit here some minor edits to comments and
GHC.StaticPtr.StaticPtrInfo field names.
Authored-by: Alexander Vershilov <alexander.vershilov@tweag.
Authored-by: Facundo DomÃnguez <facundo.dominguez@tweag.io>
Test Plan: ./validate
Reviewers: simonpj, hvr, austin
Reviewed By: austin
Subscribers: carter, thomie, qnikst, mboes
Differential Revision: https://phabricator.haskell.org/D586
GHC Trac Issues: #9878
Diffstat (limited to 'includes')
| -rw-r--r-- | includes/rts/StaticPtrTable.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/includes/rts/StaticPtrTable.h b/includes/rts/StaticPtrTable.h index d863160342..9c03d05ed3 100644 --- a/includes/rts/StaticPtrTable.h +++ b/includes/rts/StaticPtrTable.h @@ -16,8 +16,8 @@ /** Inserts an entry in the Static Pointer Table. * - * The key is a fingerprint computed from the StaticName of a static pointer - * and the spe_closure is a pointer to the closure defining the table entry. + * The key is a fingerprint computed from the static pointer and the spe_closure + * is a pointer to the closure defining the table entry. * * A stable pointer to the closure is made to prevent it from being garbage * collected while the entry exists on the table. |