diff options
| author | Ben Gamari <bgamari.foss@gmail.com> | 2017-09-19 09:51:01 -0400 |
|---|---|---|
| committer | Ben Gamari <ben@smart-cactus.org> | 2017-09-19 13:37:46 -0400 |
| commit | 6252292d4f4061f6e55c7f92a399160147c4ca74 (patch) | |
| tree | a351164d82573652b5c803f8ed74a982857bfce2 /includes | |
| parent | 1db0f4a48e9db5e85782e32f074cc83bbc145cb7 (diff) | |
| download | haskell-6252292d4f4061f6e55c7f92a399160147c4ca74.tar.gz | |
rts/RetainerProfile: Adding missing closure types to isRetainer
orzo in `#ghc` reported seeing a crash due to the retainer profiler encountering
a BLOCKING_QUEUE closure, which isRetainer didn't know about. I performed an
audit to make sure that all of the valid closure types were listed; they
weren't. This is my guess of how they should appear.
Test Plan: Validate
Reviewers: simonmar, austin, erikd
Reviewed By: simonmar
Subscribers: rwbarton, thomie
GHC Trac Issues: #14235
Differential Revision: https://phabricator.haskell.org/D3967
Diffstat (limited to 'includes')
| -rw-r--r-- | includes/rts/storage/ClosureTypes.h | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/includes/rts/storage/ClosureTypes.h b/includes/rts/storage/ClosureTypes.h index 68cc919257..240982ca85 100644 --- a/includes/rts/storage/ClosureTypes.h +++ b/includes/rts/storage/ClosureTypes.h @@ -1,5 +1,5 @@ /* ---------------------------------------------------------------------------- - * + * * (c) The GHC Team, 1998-2005 * * Closure Type Constants: out here because the native code generator @@ -9,11 +9,12 @@ #pragma once -/* +/* * WARNING WARNING WARNING * - * If you add or delete any closure types, don't forget to update - * the closure flags table in rts/ClosureFlags.c. + * If you add or delete any closure types, don't forget to update the following, + * - the closure flags table in rts/ClosureFlags.c + * - isRetainer in rts/RetainerProfile.c */ /* Object tag 0 raises an internal error */ |