diff options
author | Ryan Scott <ryan.gl.scott@gmail.com> | 2016-10-14 10:40:56 -0400 |
---|---|---|
committer | Ben Gamari <ben@smart-cactus.org> | 2016-10-14 13:27:33 -0400 |
commit | d5a4e49d657682eeb6e86ae464d281974ce2f5e2 (patch) | |
tree | 215c7bbafcd067a758c4793aed7d0d581e82a4a9 /iserv | |
parent | 8c6a3d68c0301bb985aa2a462936bbcf7584ae9c (diff) | |
download | haskell-d5a4e49d657682eeb6e86ae464d281974ce2f5e2.tar.gz |
Make error when deriving an instance for a typeclass less misleading
Before, when you attempted to derive an instance for a typeclass,
e.g.,
```
class C1 (a :: Constraint) where
class C2 where
deriving instance C1 C2
```
GHC would complain that `C2`'s data constructors aren't in scope. But
that
makes no sense, since typeclasses don't have constructors! By refining
the
checks that GHC performs when deriving, we can make the error message a
little more sensible.
This also cleans up a related `DeriveAnyClass` infelicity. Before, you
wouldn't have been able to compile code like this:
```
import System.IO (Handle)
class C a
deriving instance C Handle
```
Since GHC was requiring that all data constructors of `Handle` be in
scope. But `DeriveAnyClass` doesn't even generate code that mentions
any data constructors, so this requirement is silly!
Fixes #11509.
Test Plan: make test TEST=T11509
Reviewers: simonpj, austin, bgamari
Reviewed By: simonpj, bgamari
Subscribers: thomie, simonpj
Differential Revision: https://phabricator.haskell.org/D2558
GHC Trac Issues: #11509
Diffstat (limited to 'iserv')
0 files changed, 0 insertions, 0 deletions