diff options
author | Ian Lynagh <ian@well-typed.com> | 2012-10-27 19:13:27 +0100 |
---|---|---|
committer | Ian Lynagh <ian@well-typed.com> | 2012-10-27 19:13:27 +0100 |
commit | fda30027384069e79df15a7674707a73e56288ed (patch) | |
tree | ac2cf3a0624ebd0df36755a0757f9f41fcb9b7c8 /libraries/base/Data/Maybe.hs | |
parent | 57f65911762147ae20af7e41166597e9f0c34ec8 (diff) | |
download | haskell-fda30027384069e79df15a7674707a73e56288ed.tar.gz |
Remove commented types in module export lists
These comments are rather less useful now that haddock can give docs
with the same informatino in the module synopsis.
Having to maintain them when making changes to the library is a pain,
and when people forget about doing so there is nothing that checks that
the comments are right, so mistakes tend to linger.
Of the comments that my script detected, 78 of 684 were already
incorrect in one way or another, e.g. missing context:
Text.Show.showsPrec
Comment type: Int -> a -> ShowS
Actual type: Show a => Int -> a -> ShowS
wrong context:
Numeric.readInt
Comment type: Integral a => a -> (Char -> Bool) -> (Char -> Int) -> ReadS a
Actual type: Num a => a -> (Char -> Bool) -> (Char -> Int) -> ReadS a
not following a class change (e.g. Num losing its Eq superclass):
Text.Read.Lex.readOctP
Comment type: Num a => ReadP a
Actual type: (Eq a, Num a) => ReadP a
not following the Exceptions change:
GHC.Conc.childHandler
Comment type: Exception -> IO ()
Actual type: SomeException -> IO ()
or just always been wrong:
GHC.Stable.deRefStablePtr
Comment type: StablePtr a -> a
Actual type: StablePtr a -> IO a
Diffstat (limited to 'libraries/base/Data/Maybe.hs')
-rw-r--r-- | libraries/base/Data/Maybe.hs | 25 |
1 files changed, 12 insertions, 13 deletions
diff --git a/libraries/base/Data/Maybe.hs b/libraries/base/Data/Maybe.hs index aafe8928bd..728c981755 100644 --- a/libraries/base/Data/Maybe.hs +++ b/libraries/base/Data/Maybe.hs @@ -17,19 +17,18 @@ module Data.Maybe ( - Maybe(Nothing,Just)-- instance of: Eq, Ord, Show, Read, - -- Functor, Monad, MonadPlus - - , maybe -- :: b -> (a -> b) -> Maybe a -> b - - , isJust -- :: Maybe a -> Bool - , isNothing -- :: Maybe a -> Bool - , fromJust -- :: Maybe a -> a - , fromMaybe -- :: a -> Maybe a -> a - , listToMaybe -- :: [a] -> Maybe a - , maybeToList -- :: Maybe a -> [a] - , catMaybes -- :: [Maybe a] -> [a] - , mapMaybe -- :: (a -> Maybe b) -> [a] -> [b] + Maybe(Nothing,Just) + + , maybe + + , isJust + , isNothing + , fromJust + , fromMaybe + , listToMaybe + , maybeToList + , catMaybes + , mapMaybe ) where #ifdef __GLASGOW_HASKELL__ |