summaryrefslogtreecommitdiff
path: root/libraries
diff options
context:
space:
mode:
authorCurran McConnell <curran@atidot.com>2022-08-16 03:10:56 -0400
committerMarge Bot <ben+marge-bot@smart-cactus.org>2022-10-21 02:58:01 -0400
commit8cd6f435e60f9dd14ad55a0002ff833536e9ccb2 (patch)
tree67096c26a87980089ba29908c478dfb8a59d9d76 /libraries
parent1ebd521f848289a99993f95af4e2021023537ad5 (diff)
downloadhaskell-8cd6f435e60f9dd14ad55a0002ff833536e9ccb2.tar.gz
remove a no-warn directive from GHC.Cmm.ContFlowOpt
This patch is motivated by the desire to remove the {-# OPTIONS_GHC -fno-warn-incomplete-patterns #-} directive at the top of GHC.Cmm.ContFlowOpt. (Based on the text in this coding standards doc, I understand it's a goal of the project to remove such directives.) I chose this task because I'm a new contributor to GHC, and it seemed like a good way to get acquainted with the patching process. In order to address the warning that arose when I removed the no-warn directive, I added a case to removeUnreachableBlocksProc to handle the CmmData constructor. Clearly, since this partial function has not been erroring out in the wild, its inputs are always in practice wrapped by the CmmProc constructor. Therefore the CmmData case is handled by a precise panic (which is an improvement over the partial pattern match from before).
Diffstat (limited to 'libraries')
0 files changed, 0 insertions, 0 deletions